Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 1002013003: Unit Test for WebView animating in and out of screen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index ea9d60312836a4a3c45dc9dd20850bf05028defd..2d8581322c2e658fd881def3b113cbd5b2dc2ba6 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -216,6 +216,12 @@ bool BrowserViewRenderer::OnDrawHardware() {
return false;
}
+ if (last_on_draw_global_visible_rect_.IsEmpty()) {
+ // WebView could be offscreen. Need to make sure WebView invalidates when
+ // it is animated into the screen again.
+ shared_renderer_state_.SetForceInvalidateOnNextDrawGLOnUI(true);
+ }
+
ReturnResourceFromParent();
if (shared_renderer_state_.HasCompositorFrameOnUI()) {
TRACE_EVENT_INSTANT0("android_webview",

Powered by Google App Engine
This is Rietveld 408576698