Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: android_webview/browser/browser_view_renderer.h

Issue 1002013003: Unit Test for WebView animating in and out of screen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
6 #define ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_ 6 #define ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
7 7
8 #include "android_webview/browser/parent_compositor_draw_constraints.h" 8 #include "android_webview/browser/parent_compositor_draw_constraints.h"
9 #include "android_webview/browser/shared_renderer_state.h" 9 #include "android_webview/browser/shared_renderer_state.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 float max_page_scale_factor) override; 105 float max_page_scale_factor) override;
106 bool IsExternalFlingActive() const override; 106 bool IsExternalFlingActive() const override;
107 void DidOverscroll(gfx::Vector2dF accumulated_overscroll, 107 void DidOverscroll(gfx::Vector2dF accumulated_overscroll,
108 gfx::Vector2dF latest_overscroll_delta, 108 gfx::Vector2dF latest_overscroll_delta,
109 gfx::Vector2dF current_fling_velocity) override; 109 gfx::Vector2dF current_fling_velocity) override;
110 110
111 void UpdateParentDrawConstraints(); 111 void UpdateParentDrawConstraints();
112 void DidSkipCommitFrame(); 112 void DidSkipCommitFrame();
113 void DetachFunctorFromView(); 113 void DetachFunctorFromView();
114 114
115 // Visible for testing.
116 ParentCompositorDrawConstraints& parent_draw_constraints() {
boliu 2015/03/13 14:23:05 add _for_testing to the method name, return type s
hush (inactive) 2015/03/13 17:46:53 Done.
117 return parent_draw_constraints_;
118 }
119
115 private: 120 private:
116 void SetTotalRootLayerScrollOffset(gfx::Vector2dF new_value_dip); 121 void SetTotalRootLayerScrollOffset(gfx::Vector2dF new_value_dip);
117 bool CanOnDraw(); 122 bool CanOnDraw();
118 // Checks the continuous invalidate and block invalidate state, and schedule 123 // Checks the continuous invalidate and block invalidate state, and schedule
119 // invalidates appropriately. If |force_invalidate| is true, then send a view 124 // invalidates appropriately. If |force_invalidate| is true, then send a view
120 // invalidate regardless of compositor expectation. If |skip_reschedule_tick| 125 // invalidate regardless of compositor expectation. If |skip_reschedule_tick|
121 // is true and if there is already a pending fallback tick, don't reschedule 126 // is true and if there is already a pending fallback tick, don't reschedule
122 // them. 127 // them.
123 void EnsureContinuousInvalidation(bool force_invalidate, 128 void EnsureContinuousInvalidation(bool force_invalidate,
124 bool skip_reschedule_tick); 129 bool skip_reschedule_tick);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 // visible skew (especially noticeable when scrolling up and down in the same 209 // visible skew (especially noticeable when scrolling up and down in the same
205 // spot over a period of time). 210 // spot over a period of time).
206 gfx::Vector2dF overscroll_rounding_error_; 211 gfx::Vector2dF overscroll_rounding_error_;
207 212
208 DISALLOW_COPY_AND_ASSIGN(BrowserViewRenderer); 213 DISALLOW_COPY_AND_ASSIGN(BrowserViewRenderer);
209 }; 214 };
210 215
211 } // namespace android_webview 216 } // namespace android_webview
212 217
213 #endif // ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_ 218 #endif // ANDROID_WEBVIEW_BROWSER_BROWSER_VIEW_RENDERER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698