CrashpadClient::StartHandler(): accept database, url, and annotations arguments

handler/mac/main.cc

Index: handler/mac/main.cc
diff --git a/handler/mac/main.cc b/handler/mac/main.cc
index c8f825c56e51cbbbceefc7e02f5605fb51953af8..c0f3d8333e5020efc6034e26969ae978c1b6eafd 100644
--- a/handler/mac/main.cc
+++ b/handler/mac/main.cc
@@ -31,24 +31,12 @@
 #include "util/mach/child_port_handshake.h"
 #include "util/posix/close_stdio.h"
 #include "util/stdlib/string_number_conversion.h"
+#include "util/string/split_string.h"
 #include "util/synchronization/semaphore.h"
 
 namespace crashpad {
 namespace {
 
-bool SplitString(const std::string& string,
-                 std::string* left,
-                 std::string* right) {
-  size_t equals_pos = string.find('=');
-  if (equals_pos == 0 || equals_pos == std::string::npos) {
-    return false;
-  }
-
-  left->assign(string, 0, equals_pos);
-  right->assign(string, equals_pos + 1, std::string::npos);
-  return true;
-}
-
 void Usage(const std::string& me) {
   fprintf(stderr,
 "Usage: %s [OPTION]...\n"
@@ -57,6 +45,7 @@ void Usage(const std::string& me) {
 "      --annotation=KEY=VALUE  set a process annotation in each crash report\n"
 "      --database=PATH         store the crash report database at PATH\n"
 "      --handshake-fd=FD       establish communication with the client over FD\n"
+"      --url=URL               send crash reports to the Breakpad server at URL\n"

[Robert Sesek, 2015/03/12 18:01:09]

"to this Breakpad server URL" would be 80cols

[Mark Mentovai, 2015/03/12 18:14:04]

Robert Sesek wrote:
Updated, but I’ve allowed these --help strings to go past 80 because they become
unreadable in the source otherwise, as long as the actual line that gets printed
isn’t longer than 80.

 "      --help                  display this help and exit\n"
 "      --version               output version information and exit\n",
           me.c_str());