CrashpadClient::StartHandler(): accept database, url, and annotations arguments

CrashpadClient::StartHandler(): accept database, url, and annotations arguments.

This makes it easier for clients to start the Crashpad handler, instead
of requiring them to know how to construct arguments for the handler
themselves. Note in the TEST that -a is no longer required.

TEST=run_with_crashpad --handler crashpad_handler \
         --database=/tmp/crashpad_db \
         --url=https://clients2.google.com/cr/staging_report \
         --annotation=prod=crashpad \
         --annotation=ver=0.7.0 \
         crashy_program

R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/29cdc74579cbaddaa4200c8eb16965bc29a441f1

[Mark Mentovai, 2015-03-12 16:58:47]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2015-03-12 18:01:09]

https://codereview.chromium.org/1001993002/diff/1/handler/mac/main.cc
File handler/mac/main.cc (right):

https://codereview.chromium.org/1001993002/diff/1/handler/mac/main.cc#newcode48
handler/mac/main.cc:48: "      --url=URL               send crash reports to the
Breakpad server at URL\n"
"to this Breakpad server URL" would be 80cols

https://codereview.chromium.org/1001993002/diff/1/tools/mac/run_with_crashpad.cc
File tools/mac/run_with_crashpad.cc (right):

https://codereview.chromium.org/1001993002/diff/1/tools/mac/run_with_crashpad...
tools/mac/run_with_crashpad.cc:41: "      --annotation=KEY=VALUE  passed to the
handler as an --annotation argument\n"
80cols here or does it not matter?

https://codereview.chromium.org/1001993002/diff/1/util/string/split_string.h
File util/string/split_string.h (right):

https://codereview.chromium.org/1001993002/diff/1/util/string/split_string.h#...
util/string/split_string.h:31: bool SplitString(const std::string& string,
I'd expect something generic sounding like SplitString to take the char on which
to split.

[Mark Mentovai, 2015-03-12 18:14:04]

Thanks, I made SplitString() more generic.

https://codereview.chromium.org/1001993002/diff/1/handler/mac/main.cc
File handler/mac/main.cc (right):

https://codereview.chromium.org/1001993002/diff/1/handler/mac/main.cc#newcode48
handler/mac/main.cc:48: "      --url=URL               send crash reports to the
Breakpad server at URL\n"
Robert Sesek wrote:
> "to this Breakpad server URL" would be 80cols

Updated, but I’ve allowed these --help strings to go past 80 because they become
unreadable in the source otherwise, as long as the actual line that gets printed
isn’t longer than 80.

[Robert Sesek, 2015-03-12 18:26:36]

LGTM

[Mark Mentovai, 2015-03-12 18:28:23]

Committed patchset #3 (id:40001) manually as
29cdc74579cbaddaa4200c8eb16965bc29a441f1 (presubmit successful).