Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: handler/mac/exception_handler_server.cc

Issue 1001943002: handler/mac: Log a warning when an exception message has a suspicious (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: MACH_MSG_TYPE_MAKE_SEND_ONCE Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « handler/mac/crash_report_exception_handler.cc ('k') | util/mach/exception_ports_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: handler/mac/exception_handler_server.cc
diff --git a/handler/mac/exception_handler_server.cc b/handler/mac/exception_handler_server.cc
index 803ebfdce1d74338bcd0e48e9cfa781349e61f5e..faf8b6e03e568feeda63a9448267a5f7f97b78be 100644
--- a/handler/mac/exception_handler_server.cc
+++ b/handler/mac/exception_handler_server.cc
@@ -26,9 +26,8 @@ namespace crashpad {
namespace {
-class ExceptionHandlerServerRun
- : public UniversalMachExcServer::Interface,
- public NotifyServer::Interface {
+class ExceptionHandlerServerRun : public UniversalMachExcServer::Interface,
+ public NotifyServer::Interface {
public:
ExceptionHandlerServerRun(
mach_port_t exception_port,
@@ -100,7 +99,7 @@ class ExceptionHandlerServerRun
mach_msg_return_t mr =
MachMessageServer::Run(&composite_mach_message_server_,
server_port_set,
- MACH_MSG_OPTION_NONE,
+ kMachMessageReceiveAuditTrailer,
MachMessageServer::kOneShot,
MachMessageServer::kReceiveLargeIgnore,
kMachMessageTimeoutWaitIndefinitely);
@@ -148,9 +147,9 @@ class ExceptionHandlerServerRun
// NotifyServer::Interface:
kern_return_t DoMachNotifyPortDeleted(
- notify_port_t notify,
- mach_port_name_t name,
- const mach_msg_trailer_t* trailer) override {
+ notify_port_t notify,
+ mach_port_name_t name,
+ const mach_msg_trailer_t* trailer) override {
return UnimplementedNotifyRoutine(notify);
}
« no previous file with comments | « handler/mac/crash_report_exception_handler.cc ('k') | util/mach/exception_ports_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698