Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1001943002: handler/mac: Log a warning when an exception message has a suspicious (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

handler/mac: Log a warning when an exception message has a suspicious origin. This adds AuditPIDFromMachMessageTrailer() to get the process ID of a Mach message’s sender. Exception messages are considered suspicious when not sent by the kernel or the exception process. TEST=crashpad_util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5f19d639e1125eef56ee3d6cb43934dcf30c08e8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review feedback #

Patch Set 3 : MACH_MSG_TYPE_MAKE_SEND_ONCE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -46 lines) Patch
M handler/mac/crash_report_exception_handler.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M handler/mac/exception_handler_server.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download
M util/mach/exception_ports_test.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M util/mach/mach_message.h View 1 2 chunks +26 lines, -0 lines 0 comments Download
M util/mach/mach_message.cc View 1 2 chunks +36 lines, -0 lines 0 comments Download
M util/mach/mach_message_test.cc View 1 2 2 chunks +44 lines, -0 lines 0 comments Download
M util/mach/notify_server_test.cc View 1 12 chunks +39 lines, -28 lines 0 comments Download
M util/test/mac/mach_multiprocess.cc View 1 4 chunks +14 lines, -10 lines 0 comments Download
M util/util.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-12 15:50:46 UTC) #2
Robert Sesek
https://codereview.chromium.org/1001943002/diff/1/util/mach/notify_server_test.cc File util/mach/notify_server_test.cc (right): https://codereview.chromium.org/1001943002/diff/1/util/mach/notify_server_test.cc#newcode242 util/mach/notify_server_test.cc:242: MACH_RCV_TRAILER_ELEMENTS(MACH_RCV_TRAILER_AUDIT), Would it be useful to collapse this expression ...
5 years, 9 months ago (2015-03-12 16:01:06 UTC) #3
Mark Mentovai
Updated. https://codereview.chromium.org/1001943002/diff/1/util/mach/notify_server_test.cc File util/mach/notify_server_test.cc (right): https://codereview.chromium.org/1001943002/diff/1/util/mach/notify_server_test.cc#newcode242 util/mach/notify_server_test.cc:242: MACH_RCV_TRAILER_ELEMENTS(MACH_RCV_TRAILER_AUDIT), Robert Sesek wrote: > Would it be ...
5 years, 9 months ago (2015-03-12 17:50:52 UTC) #5
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-12 17:57:51 UTC) #6
Mark Mentovai
5 years, 9 months ago (2015-03-12 18:03:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
5f19d639e1125eef56ee3d6cb43934dcf30c08e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698