Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1001833006: remove slower scalar code in favor of vectors (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove slower scalar code in favor of vectors BUG=skia: Committed: https://skia.googlesource.com/skia/+/c08330f1601aeca7f10aeb2194118decbfbf83e1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -145 lines) Patch
M bench/GeometryBench.cpp View 3 chunks +6 lines, -38 lines 0 comments Download
M src/core/SkGeometry.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkGeometry.cpp View 4 chunks +3 lines, -73 lines 1 comment Download
M tests/GeometryTest.cpp View 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
no gm diffs on my mac
5 years, 9 months ago (2015-03-26 14:00:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001833006/1
5 years, 9 months ago (2015-03-26 14:00:48 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-26 14:00:49 UTC) #5
mtklein
brave, lgtm https://codereview.chromium.org/1001833006/diff/1/src/core/SkGeometry.cpp File src/core/SkGeometry.cpp (right): https://codereview.chromium.org/1001833006/diff/1/src/core/SkGeometry.cpp#newcode205 src/core/SkGeometry.cpp:205: SkChopQuadAt(src, dst, 0.5f); return; No need for ...
5 years, 9 months ago (2015-03-26 14:24:30 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 14:26:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c08330f1601aeca7f10aeb2194118decbfbf83e1

Powered by Google App Engine
This is Rietveld 408576698