base/strings/string_piece_unittest.cc - Issue 1001833005: Update from https://crrev.com/320343

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_piece_unittest.cc

Issue 1001833005: Update from https://crrev.com/320343 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Supress Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/string_piece_unittest.cc

diff --git a/base/strings/string_piece_unittest.cc b/base/strings/string_piece_unittest.cc

index 7f50cfbf6794d0256b6049f0ef634cf21e52f03c..53366036d6fb0ba1c46d744a2a90457c833705dc 100644

--- a/base/strings/string_piece_unittest.cc

+++ b/base/strings/string_piece_unittest.cc

@@ -602,13 +602,13 @@ TYPED_TEST(CommonStringPieceTest, CheckComparisons2) {

// check comparison operations on strings longer than 4 bytes.

ASSERT_TRUE(abc == BasicStringPiece<TypeParam>(alphabet));

- ASSERT_TRUE(abc.compare(BasicStringPiece<TypeParam>(alphabet)) == 0);

+ ASSERT_EQ(abc.compare(BasicStringPiece<TypeParam>(alphabet)), 0);

ASSERT_TRUE(abc < BasicStringPiece<TypeParam>(alphabet_z));

- ASSERT_TRUE(abc.compare(BasicStringPiece<TypeParam>(alphabet_z)) < 0);

+ ASSERT_LT(abc.compare(BasicStringPiece<TypeParam>(alphabet_z)), 0);

ASSERT_TRUE(abc > BasicStringPiece<TypeParam>(alphabet_y));

- ASSERT_TRUE(abc.compare(BasicStringPiece<TypeParam>(alphabet_y)) > 0);

+ ASSERT_GT(abc.compare(BasicStringPiece<TypeParam>(alphabet_y)), 0);

}

// Test operations only supported by std::string version.

« no previous file with comments | « base/strings/nullable_string16.h ('k') | base/strings/string_split.cc » ('j') | no next file with comments »