base/process/kill_mac.cc - Issue 1001833005: Update from https://crrev.com/320343

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/kill_mac.cc

Issue 1001833005: Update from https://crrev.com/320343 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Supress Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/process/kill_mac.cc

diff --git a/base/process/kill_mac.cc b/base/process/kill_mac.cc

index 8c424009864951636e7e6501341931976beab670..a4e0a14cf8f3f620e9fb23ac6b97145c64b5ecdb 100644

--- a/base/process/kill_mac.cc

+++ b/base/process/kill_mac.cc

@@ -66,8 +66,8 @@ void BlockingReap(pid_t child) {

// work in that case, but waitpid won't, and killing a non-child might not be

// the best approach.

void WaitForChildToDie(pid_t child, int timeout) {

- DCHECK(child > 0);

- DCHECK(timeout > 0);

+ DCHECK_GT(child, 0);

+ DCHECK_GT(timeout, 0);

// DON'T ADD ANY EARLY RETURNS TO THIS FUNCTION without ensuring that

// |child| has been reaped. Specifically, even if a kqueue, kevent, or other

« no previous file with comments | « base/process/internal_linux.h ('k') | base/process/memory.cc » ('j') | no next file with comments »