Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: skia/BUILD.gn

Issue 1001833005: Update from https://crrev.com/320343 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Supress Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdch/win/config.h ('k') | skia/config/SkUserConfig.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index 472a8cf755eb520b87696c89e83d553b14a1dd72..2357a7f6a2cc7710dbab60564302c4ac38838087 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -116,9 +116,6 @@ config("skia_config") {
"//third_party/skia/include/pipe",
"//third_party/skia/include/ports",
"//third_party/skia/include/utils",
-
- # need to move this to internal. see crbug.com/457691
- "//third_party/skia/src/core",
]
defines = gypi_skia_defines.skia_for_chromium_defines
@@ -126,7 +123,10 @@ config("skia_config") {
defines += []
if (component_mode == "shared_library") {
- defines += [ "SKIA_DLL" ]
+ defines += [
+ "SKIA_DLL",
+ "GR_GL_IGNORE_ES3_MSAA=0",
+ ]
}
if (skia_support_gpu) {
@@ -157,6 +157,7 @@ config("skia_library_config") {
# exported to dependents. It's not clear if this is on purpose, but this
# matches the GYP build.
include_dirs = [
+ "//third_party/skia/src/core",
"//third_party/skia/src/image",
"//third_party/skia/src/opts",
"//third_party/skia/src/pdf",
@@ -231,7 +232,12 @@ config("skia_library_config") {
"//third_party/skia/src/utils/win",
]
- defines += [ "SK_FONTHOST_USES_FONTMGR" ]
+ defines += [
+ # On windows, GDI handles are a scarse system-wide resource so we have to
+ # keep the glyph cache, which holds up to 4 GDI handles per entry, to a
+ # fairly small size. http://crbug.com/314387
+ "SK_DEFAULT_FONT_CACHE_COUNT_LIMIT=256",
+ ]
cflags = [
"/wd4244", # conversion from 'type1( __int64)' to 'type2 (unsigned int)'
@@ -242,6 +248,7 @@ config("skia_library_config") {
"/wd4554", # 'operator' : check operator precedence for possible error
"/wd4748", # compiler will disable optimizations if a function has inline
# assembly code contains flow control(jmp or jcc) statements.
+
"/wd4800", # forcing value to bool 'true/false'(assigning int to bool).
]
}
@@ -486,14 +493,6 @@ component("skia") {
"//third_party/zlib",
]
- if (is_win) {
- configs -= [
- # Some files define WIN32_LEAN_AND_MEAN and we want to avoid a duplicate
- # definition warning.
- "//build/config/win:lean_and_mean",
- ]
- }
-
if (is_linux) {
configs += [
"//build/config/linux:fontconfig",
@@ -617,3 +616,28 @@ test("skia_unittests") {
"//ui/gfx/geometry",
]
}
+
+if (is_linux && !is_chromeos) {
+ # TODO(GYP): Figure out which of these work and are needed on other platforms.
+ executable("image_operations_bench") {
+ sources = [
+ "ext/image_operations_bench.cc",
+ ]
+
+ deps = [
+ ":skia",
+ "//base",
+ ]
+ }
+
+ executable("filter_fuzz_stub") {
+ sources = [
+ "tools/filter_fuzz_stub/filter_fuzz_stub.cc",
+ ]
+
+ deps = [
+ ":skia",
+ "//base",
+ ]
+ }
+}
« no previous file with comments | « sdch/win/config.h ('k') | skia/config/SkUserConfig.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698