base/threading/sequenced_worker_pool.cc - Issue 1001833005: Update from https://crrev.com/320343

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/sequenced_worker_pool.cc

Issue 1001833005: Update from https://crrev.com/320343 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Supress Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/threading/sequenced_worker_pool.cc

diff --git a/base/threading/sequenced_worker_pool.cc b/base/threading/sequenced_worker_pool.cc

index 19b81b7b4b32a32d58bd74e2f8e237aa082f1722..f20d9972261c3b26269564ba3b198ce1aba1be49 100644

--- a/base/threading/sequenced_worker_pool.cc

+++ b/base/threading/sequenced_worker_pool.cc

@@ -1091,7 +1091,7 @@ int SequencedWorkerPool::Inner::PrepareToStartAdditionalThreadIfHelpful() {

void SequencedWorkerPool::Inner::FinishStartingAdditionalThread(

int thread_number) {

// Called outside of the lock.

- DCHECK(thread_number > 0);

+ DCHECK_GT(thread_number, 0);

// The worker is assigned to the list when the thread actually starts, which

// will manage the memory of the pointer.