Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 1001833005: Update from https://crrev.com/320343 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Supress Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index 5e6d9d9035dc7de2d9a487657183a6daf38c1d90..bf5b19ef8b4e78ae5d1a6ccabeed338e9a57f19f 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -544,6 +544,7 @@ _STATES = {
# named types are used in 'cmd_buffer_functions.txt'.
# type: The actual GL type of the named type.
# valid: The list of values that are valid for both the client and the service.
+# valid_es3: The list of values that are valid in OpenGL ES 3, but not ES 2.
# invalid: Examples of invalid values for the type. At least these values
# should be tested to be invalid.
# is_complete: The list of valid values of type are final and will not be
@@ -584,6 +585,14 @@ _NAMED_TYPE_INFO = {
'GL_ARRAY_BUFFER',
'GL_ELEMENT_ARRAY_BUFFER',
],
+ 'valid_es3': [
+ 'GL_COPY_READ_BUFFER',
+ 'GL_COPY_WRITE_BUFFER',
+ 'GL_PIXEL_PACK_BUFFER',
+ 'GL_PIXEL_UNPACK_BUFFER',
+ 'GL_TRANSFORM_FEEDBACK_BUFFER',
+ 'GL_UNIFORM_BUFFER',
+ ],
'invalid': [
'GL_RENDERBUFFER',
],
@@ -598,6 +607,20 @@ _NAMED_TYPE_INFO = {
'GL_RENDERBUFFER',
],
},
+ 'MapBufferAccess': {
+ 'type': 'GLenum',
+ 'valid': [
+ 'GL_MAP_READ_BIT',
+ 'GL_MAP_WRITE_BIT',
+ 'GL_MAP_INVALIDATE_RANGE_BIT',
+ 'GL_MAP_INVALIDATE_BUFFER_BIT',
+ 'GL_MAP_FLUSH_EXPLICIT_BIT',
+ 'GL_MAP_UNSYNCHRONIZED_BIT',
+ ],
+ 'invalid': [
+ 'GL_SYNC_FLUSH_COMMANDS_BIT',
+ ],
+ },
'Bufferiv': {
'type': 'GLenum',
'valid': [
@@ -1979,6 +2002,11 @@ _FUNCTION_INFO = {
'defer_draws': True,
'trace_level': 2,
},
+ 'DrawRangeElements': {
+ 'type': 'Manual',
+ 'gen_cmd': 'False',
+ 'unsafe': True,
+ },
'Enable': {
'decoder_func': 'DoEnable',
'impl_func': False,
@@ -2494,6 +2522,16 @@ _FUNCTION_INFO = {
'client_test': False,
'pepper_interface': 'ChromiumMapSub',
},
+ 'MapBufferRange': {
+ 'type': 'Custom',
+ 'data_transfer_methods': ['shm'],
+ 'cmd_args': 'GLenumBufferTarget target, GLintptrNotNegative offset, '
+ 'GLsizeiptr size, GLbitfieldMapBufferAccess access, '
+ 'uint32_t data_shm_id, uint32_t data_shm_offset, '
+ 'uint32_t result_shm_id, uint32_t result_shm_offset',
+ 'unsafe': True,
+ 'result': ['uint32_t'],
+ },
'PauseTransformFeedback': {
'unsafe': True,
},
@@ -2879,6 +2917,10 @@ _FUNCTION_INFO = {
'client_test': False,
'pepper_interface': 'ChromiumMapSub',
},
+ 'UnmapBuffer': {
+ 'type': 'Custom',
+ 'unsafe': True,
+ },
'UnmapTexSubImage2DCHROMIUM': {
'gen_cmd': False,
'extension': True,
@@ -7507,6 +7549,10 @@ class NamedType(object):
self.invalid = info['invalid']
else:
self.invalid = []
+ if 'valid_es3' in info:
+ self.valid_es3 = info['valid_es3']
+ else:
+ self.valid_es3 = []
def GetType(self):
return self.info['type']
@@ -7517,6 +7563,9 @@ class NamedType(object):
def GetValidValues(self):
return self.valid
+ def GetValidValuesES3(self):
+ return self.valid_es3
+
def IsConstant(self):
if not 'is_complete' in self.info:
return False
@@ -9816,6 +9865,13 @@ extern const NameToFunc g_gles2_function_table[] = {
file.Write(" %s,\n" % value)
file.Write("};\n")
file.Write("\n")
+ if named_type.GetValidValuesES3():
+ file.Write("static const %s valid_%s_table_es3[] = {\n" %
+ (named_type.GetType(), ToUnderscore(name)))
+ for value in named_type.GetValidValuesES3():
+ file.Write(" %s,\n" % value)
+ file.Write("};\n")
+ file.Write("\n")
file.Write("Validators::Validators()")
pre = ' : '
for count, name in enumerate(names):
@@ -9834,6 +9890,18 @@ extern const NameToFunc g_gles2_function_table[] = {
pre = ',\n '
file.Write(" {\n");
file.Write("}\n\n");
+
+ file.Write("void Validators::AddES3Values() {\n")
+ for name in names:
+ named_type = NamedType(_NAMED_TYPE_INFO[name])
+ if named_type.GetValidValuesES3():
+ code = """ %(name)s.AddValues(
+ valid_%(name)s_table_es3, arraysize(valid_%(name)s_table_es3));
+"""
+ file.Write(code % {
+ 'name': ToUnderscore(name),
+ })
+ file.Write("}\n\n");
file.Close()
self.generated_cpp_filenames.append(file.filename)
@@ -9892,9 +9960,13 @@ const size_t GLES2Util::enum_to_string_table_len_ =
if _NAMED_TYPE_INFO[enum]['type'] == 'GLenum':
file.Write("std::string GLES2Util::GetString%s(uint32_t value) {\n" %
enum)
- if len(_NAMED_TYPE_INFO[enum]['valid']) > 0:
+ valid_list = _NAMED_TYPE_INFO[enum]['valid']
+ if 'valid_es3' in _NAMED_TYPE_INFO[enum]:
+ valid_list = valid_list + _NAMED_TYPE_INFO[enum]['valid_es3']
+ assert len(valid_list) == len(set(valid_list))
+ if len(valid_list) > 0:
file.Write(" static const EnumToString string_table[] = {\n")
- for value in _NAMED_TYPE_INFO[enum]['valid']:
+ for value in valid_list:
file.Write(' { %s, "%s" },\n' % (value, value))
file.Write(""" };
return GLES2Util::GetQualifiedEnumString(
« no previous file with comments | « gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc ('k') | gpu/command_buffer/client/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698