Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 1001833002: Rename default -> initial style and use singletons. (Closed)

Created:
5 years, 9 months ago by rune
Modified:
5 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-rendering, blink-reviews-style_chromium.org, dglazkov+blink, Dominik Röttsches, eae+blinkwatch, ed+blinkwatch_opera.com, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename default -> initial style and use singletons. Default style is normally referred to the style after UA style has been applied. Renamed to 'initial' in the cases where we really mean initial style to avoid confusion. Made initial style construction singletons by making the methods in LayoutStyle and SVGLayoutStyle private. There were a couple of places where extra copies were created unnecessarily. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -42 lines) Patch
M Source/core/css/CSSCalculationValueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutFullScreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/style/LayoutStyle.h View 1 chunk +10 lines, -4 lines 0 comments Download
M Source/core/layout/style/LayoutStyle.cpp View 2 chunks +11 lines, -17 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyle.cpp View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rune
5 years, 9 months ago (2015-03-12 13:07:01 UTC) #2
leviw_travelin_and_unemployed
Great! LGTM.
5 years, 9 months ago (2015-03-12 20:12:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001833002/1
5 years, 9 months ago (2015-03-12 20:13:07 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 20:16:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191795

Powered by Google App Engine
This is Rietveld 408576698