Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 100183003: Make the license header check an error for PRESUBMIT. (Closed)

Created:
7 years ago by aurimas (slooooooooow)
Modified:
7 years ago
Reviewers:
newt (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Make the license header check an error for PRESUBMIT. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/android/checkstyle/chromium-style-5.0.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aurimas (slooooooooow)
Hey Newton, PTAL! Aurimas
7 years ago (2013-12-03 01:37:04 UTC) #1
newt (away)
Once copyright headers are fixed in all existing code, this lgtm.
7 years ago (2013-12-03 01:44:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/100183003/1
7 years ago (2013-12-03 01:50:11 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-03 02:30:45 UTC) #4
Message was sent while issue was closed.
Change committed as 238275

Powered by Google App Engine
This is Rietveld 408576698