Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 100183002: Remove SkImageRef and related functionality. (Closed)

Created:
7 years ago by hal.canary
Modified:
6 years, 6 months ago
Reviewers:
scroggo, djsollen, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove SkImageRef and related functionality. From here on out, use SkDecodingImageGenerator+SkDiscardablePixelRef. R=scroggo@google.com Committed: https://skia.googlesource.com/skia/+/479bb60

Patch Set 1 : rebase #

Total comments: 1

Patch Set 2 : more #

Patch Set 3 : REBASED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1053 lines) Patch
M gyp/images.gyp View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M gyp/public_headers.gypi View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D include/images/SkImageRef.h View 1 2 1 chunk +0 lines, -104 lines 0 comments Download
D include/images/SkImageRef_GlobalPool.h View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
D include/images/SkImages.h View 1 chunk +0 lines, -14 lines 0 comments Download
D src/images/SkImageRef.cpp View 1 2 1 chunk +0 lines, -212 lines 0 comments Download
D src/images/SkImageRefPool.h View 1 chunk +0 lines, -49 lines 0 comments Download
D src/images/SkImageRefPool.cpp View 1 chunk +0 lines, -192 lines 0 comments Download
D src/images/SkImageRef_GlobalPool.cpp View 1 2 1 chunk +0 lines, -100 lines 0 comments Download
D src/images/SkImageRef_ashmem.h View 1 2 1 chunk +0 lines, -47 lines 0 comments Download
D src/images/SkImageRef_ashmem.cpp View 1 2 1 chunk +0 lines, -230 lines 0 comments Download
D src/images/SkImages.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/ports/SkImageDecoder_empty.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hal.canary
NOT READY for primetime
7 years ago (2013-12-06 15:53:54 UTC) #1
hal.canary
This CL is ready to go once I get an okay from our Android people.
6 years, 11 months ago (2014-01-02 19:20:21 UTC) #2
scroggo
https://codereview.chromium.org/100183002/diff/90001/src/ports/SkGlobalInitialization_default.cpp File src/ports/SkGlobalInitialization_default.cpp (left): https://codereview.chromium.org/100183002/diff/90001/src/ports/SkGlobalInitialization_default.cpp#oldcode110 src/ports/SkGlobalInitialization_default.cpp:110: SkImages::InitializeFlattenables(); Please remove similar code in src/ports/SkImageDecoder_empty.cpp and src/ports/src/ports/SkGlobalInitialization_chromium.cpp
6 years, 11 months ago (2014-01-07 16:01:05 UTC) #3
scroggo
On 2014/01/07 16:01:05, scroggo wrote: > https://codereview.chromium.org/100183002/diff/90001/src/ports/SkGlobalInitialization_default.cpp > File src/ports/SkGlobalInitialization_default.cpp (left): > > https://codereview.chromium.org/100183002/diff/90001/src/ports/SkGlobalInitialization_default.cpp#oldcode110 > ...
6 years, 11 months ago (2014-01-07 16:04:36 UTC) #4
hal.canary
On 2014/01/07 16:01:05, scroggo wrote: > https://codereview.chromium.org/100183002/diff/90001/src/ports/SkGlobalInitialization_default.cpp > File src/ports/SkGlobalInitialization_default.cpp (left): > > https://codereview.chromium.org/100183002/diff/90001/src/ports/SkGlobalInitialization_default.cpp#oldcode110 > ...
6 years, 11 months ago (2014-01-08 21:38:42 UTC) #5
scroggo
lgtm
6 years, 11 months ago (2014-01-08 21:43:57 UTC) #6
scroggo
On 2014/01/08 21:43:57, scroggo wrote: > lgtm Looking back at this as I try to ...
6 years, 8 months ago (2014-04-03 20:26:35 UTC) #7
scroggo
On 2014/04/03 20:26:35, scroggo wrote: > On 2014/01/08 21:43:57, scroggo wrote: > > lgtm > ...
6 years, 6 months ago (2014-06-04 14:22:49 UTC) #8
hal.canary
On 2014/06/04 14:22:49, scroggo wrote: > I have removed all SkImageRef functionality from Android. LGTM ...
6 years, 6 months ago (2014-06-04 14:25:10 UTC) #9
reed1
On 2014/06/04 14:25:10, Hal Canary wrote: > On 2014/06/04 14:22:49, scroggo wrote: > > > ...
6 years, 6 months ago (2014-06-04 14:28:45 UTC) #10
hal.canary
6 years, 6 months ago (2014-06-04 18:39:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 manually as r479bb60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698