Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1001733003: compat/mac: 10.6 SDK compatibility for pre-Xcode 4.2 10.6 SDK (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org, Daniele Castagna
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

compat/mac: 10.6 SDK compatibility for pre-Xcode 4.2 10.6 SDK. Some definitions were added to the 10.6 SDK during its lifetime, and aren’t present in older versions of the SDK. The AVX definitions are in this group. Apparently, not all of Chrome’s builders use the same version of this SDK. A try bot failure was encountered for https://codereview.chromium.org/1011503002/ in http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/33868/steps/compile%20%28with%20patch%29/logs/stdio. This provides definitions in compat for when they aren’t available from the SDK. TEST=compile R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/98cca0e5fcb486153ca55f981f8f65ba6da5adea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M compat/mac/mach/mach.h View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-16 16:45:16 UTC) #2
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-16 17:35:01 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-16 17:41:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
98cca0e5fcb486153ca55f981f8f65ba6da5adea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698