cc/PRESUBMIT.py - Issue 100173010: cc: add git cl format presubmit warning

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/PRESUBMIT.py

Issue 100173010: cc: add git cl format presubmit warning (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: old chunk mismatch Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Top-level presubmit script for cc.	5 """Top-level presubmit script for cc.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for

8 details on the presubmit API built into gcl.	8 details on the presubmit API built into gcl.

9 """	9 """

10	10

(...skipping 203 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
214	214

215	215

216 def CheckChangeOnUpload(input_api, output_api):	216 def CheckChangeOnUpload(input_api, output_api):

217 results = []	217 results = []

218 results += CheckAsserts(input_api, output_api)	218 results += CheckAsserts(input_api, output_api)

219 results += CheckStdAbs(input_api, output_api)	219 results += CheckStdAbs(input_api, output_api)

220 results += CheckPassByValue(input_api, output_api)	220 results += CheckPassByValue(input_api, output_api)

221 results += CheckChangeLintsClean(input_api, output_api)	221 results += CheckChangeLintsClean(input_api, output_api)

222 results += CheckTodos(input_api, output_api)	222 results += CheckTodos(input_api, output_api)

223 results += CheckNamespace(input_api, output_api)	223 results += CheckNamespace(input_api, output_api)

	224 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

224 return results	225 return results

225	226

226 def GetPreferredTrySlaves(project, change):	227 def GetPreferredTrySlaves(project, change):

227 return [	228 return [

228 'linux_layout_rel',	229 'linux_layout_rel',

229 'win_gpu',	230 'win_gpu',

230 'linux_gpu',	231 'linux_gpu',

231 'mac_gpu',	232 'mac_gpu',

232 'mac_gpu_retina',	233 'mac_gpu_retina',

233 ]	234 ]

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »