Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 100173005: Break out the basic reliable QUIC stream functionality from the (Closed)

Created:
7 years ago by ramant (doing other things)
Modified:
7 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Break out the basic reliable QUIC stream functionality from the headers-capable QUIC stream functionality. The crypto stream does not do have header processing, and and the soon-to-be-written headers stream will not have header processing in the way that data streams do. No functionality change. Refactor ReliableQuicStream class. Merge internal change: 57796557 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+750 lines, -1023 lines) Patch
M net/net.gyp View 3 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_client_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_stream.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A net/quic/quic_data_stream.h View 1 chunk +140 lines, -0 lines 0 comments Download
A net/quic/quic_data_stream.cc View 1 chunk +333 lines, -0 lines 0 comments Download
A + net/quic/quic_data_stream_test.cc View 15 chunks +17 lines, -127 lines 0 comments Download
M net/quic/quic_reliable_client_stream.h View 5 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M net/quic/quic_session.h View 7 chunks +15 lines, -14 lines 0 comments Download
M net/quic/quic_session.cc View 10 chunks +26 lines, -12 lines 0 comments Download
M net/quic/quic_session_test.cc View 13 chunks +31 lines, -30 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 20 chunks +30 lines, -29 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 7 chunks +10 lines, -84 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 6 chunks +2 lines, -295 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 2 chunks +3 lines, -335 lines 0 comments Download
A net/quic/test_tools/quic_data_stream_peer.h View 1 chunk +30 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_data_stream_peer.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +4 lines, -6 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 1 chunk +3 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
7 years ago (2013-12-12 18:57:32 UTC) #1
Ryan Hamilton
7 years ago (2013-12-12 20:56:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698