Issue 100173003: Cursor state should be global among all root windows for desktop Aura

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100173003: Cursor state should be global among all root windows for desktop Aura (Closed)

Created:
7 years ago by tdanderson

Modified:
7 years ago

Reviewers:
oshima, sky, scottmg

CC:
chromium-reviews, tfarina, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cursor state should be global among all root windows for desktop Aura DesktopNativeCursorManager currently only has knowledge of a single RootWindow, which means that it is possible for a change in cursor state within one RootWindow to cause another RootWindow to have a stale cursor state. Store a static set of RootWindows in DesktopNativeCursorManager and notify all of them of any change in cursor state. Depends on https://codereview.chromium.org/92413002/ landing first. BUG=324006 TEST=in progress

Patch Set 1 #

Patch Set 2 : make DesktopNativeCursorManager a WindowObserver #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -19 lines)			Patch
M	ui/views/widget/desktop_aura/desktop_native_cursor_manager.h	View	1	4 chunks	+20 lines, -3 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc	View	1	6 chunks	+49 lines, -5 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View	1	2 chunks	+13 lines, -11 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_win.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tdanderson

Scotts, can you please take a look? I'm in the process of writing tests.

7 years ago (2013-12-05 01:05:51 UTC) #1

tdanderson

7 years ago (2013-12-10 18:45:52 UTC) #3

Closing this issue. New approach to solving this problem:
https://codereview.chromium.org/111043002/

Expand Messages | Collapse Messages