Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1001723003: Create a common directory of widgets and css. (Closed)

Created:
5 years, 9 months ago by esprehn
Modified:
5 years, 9 months ago
Reviewers:
jrobbins, ojan
CC:
chromium-reviews, rmistry+cc_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Create a common directory of widgets and css. Move all of the widgets that are not specific to one feature and the common css sheets into a new common/ directory. R=jrobbins@chromium.org Committed: https://chromium.googlesource.com/infra/infra/+/2a05b5e3ca3cb8391a9b738a18b41f55380e9bda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -969 lines) Patch
A + appengine/chromium_rietveld/new_static/common/common.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-action.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-butterbar.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-button.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-collapsible.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-dialog.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-dialog-backdrop.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-hash-observer.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-keyboard.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-title-handler.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-toolbar.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/cr-view-handler.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/chromium_rietveld/new_static/common/forms.css View 0 chunks +-1 lines, --1 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/common.css View 1 chunk +0 lines, -107 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-action.html View 1 chunk +0 lines, -46 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-app.html View 2 chunks +4 lines, -4 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-butterbar.html View 1 chunk +0 lines, -49 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-button.html View 1 chunk +0 lines, -105 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-collapsible.html View 1 chunk +0 lines, -121 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-dialog.html View 1 chunk +0 lines, -66 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-dialog-backdrop.html View 1 chunk +0 lines, -18 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-hash-observer.html View 1 chunk +0 lines, -50 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue.html View 2 chunks +8 lines, -8 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-discard-drafts-dialog.html View 1 chunk +5 lines, -5 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-edit-dialog.html View 1 chunk +5 lines, -5 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-editor.html View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-inbox.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-inbox-section.html View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-list.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-message.html View 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-message-reply.html View 1 chunk +4 lines, -4 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-messages.html View 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-meta.html View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-patchfile.html View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html View 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-patchsets.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-publish-dialog.html View 1 chunk +6 lines, -6 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-issue-revert-dialog.html View 1 chunk +5 lines, -5 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-keyboard.html View 1 chunk +0 lines, -139 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-patch-file-message.html View 1 chunk +5 lines, -5 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-patch-file-messages.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-patchset-edit-dialog.html View 1 chunk +6 lines, -6 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-patchset-header.html View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-settings-editor.html View 1 chunk +2 lines, -2 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-title-handler.html View 1 chunk +0 lines, -37 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-toolbar.html View 1 chunk +0 lines, -27 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-try-dialog.html View 1 chunk +6 lines, -6 lines 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-try-results.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html View 1 chunk +1 line, -1 line 0 comments Download
D appengine/chromium_rietveld/new_static/components/cr-view-handler.html View 1 chunk +0 lines, -66 lines 0 comments Download
D appengine/chromium_rietveld/new_static/components/forms.css View 1 chunk +0 lines, -56 lines 0 comments Download
M appengine/chromium_rietveld/new_static/linkify/cr-linkified-text.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/chromium_rietveld/new_static/selfie/cr-gif-selfie.html View 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/chromium_rietveld/new_static/views/cr-inbox-view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/chromium_rietveld/new_static/views/cr-search-view.html View 1 chunk +5 lines, -5 lines 0 comments Download
M appengine/chromium_rietveld/new_static/views/cr-settings-view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/chromium_rietveld/new_static/views/cr-user-view.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
esprehn
5 years, 9 months ago (2015-03-11 23:36:23 UTC) #2
jrobbins
lgtm
5 years, 9 months ago (2015-03-11 23:46:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001723003/1
5 years, 9 months ago (2015-03-12 00:13:02 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 00:20:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/2a05b5e3ca3cb8391a9b738a18b41...

Powered by Google App Engine
This is Rietveld 408576698