media: Refactor PlatformVerificationFlow.

chrome/browser/chromeos/attestation/platform_verification_dialog.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ATTESTATION_PLATFORM_VERIFICATION_DIALOG_H_
 #define CHROME_BROWSER_CHROMEOS_ATTESTATION_PLATFORM_VERIFICATION_DIALOG_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/strings/string16.h"
-#include "chrome/browser/chromeos/attestation/platform_verification_flow.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "ui/views/controls/styled_label_listener.h"
 #include "ui/views/window/dialog_delegate.h"
 
 namespace content {
 class WebContents;
 }
 
 namespace chromeos {
 namespace attestation {
 
 // A tab-modal dialog UI to ask the user for PlatformVerificationFlow.
 class PlatformVerificationDialog : public views::DialogDelegateView,
                                    public views::StyledLabelListener,
                                    public content::WebContentsObserver {
  public:
+  enum ConsentResponse {
+    CONSENT_RESPONSE_NONE,
+    CONSENT_RESPONSE_ALLOW,
+    CONSENT_RESPONSE_DENY
+  };

[xhwang, 2015/03/12 00:25:00]

We should probably just replace this with PermissionStatus:

https://code.google.com/p/chromium/codesearch#chromium/src/out/Debug/gen/cont...

[ddorwin, 2015/03/12 03:58:11]

"ASK" might be a bit weird, but whatever you think is best.

[xhwang, 2015/03/12 17:35:26]

Agree that "ASK" sounds weird, but it's the standard term used throughout the
permission code.

This CL is already pretty big, so I'll leave this cleanup to a later CL.

+
+  using ConsentCallback = base::Callback<void(ConsentResponse response)>;
+
   // Initializes a tab-modal dialog for |web_contents| and |requesting_origin|
   // and shows it. Returns a non-owning pointer to the widget so that caller can
   // close the dialog and cancel the request. The returned widget is only
   // guaranteed to be valid before |callback| is called.
-  static views::Widget* ShowDialog(
-      content::WebContents* web_contents,
-      const GURL& requesting_origin,
-      const PlatformVerificationFlow::Delegate::ConsentCallback& callback);
+  static views::Widget* ShowDialog(content::WebContents* web_contents,
+                                   const GURL& requesting_origin,
+                                   const ConsentCallback& callback);
 
  protected:
   ~PlatformVerificationDialog() override;
 
  private:
-  PlatformVerificationDialog(
-      content::WebContents* web_contents,
-      const base::string16& domain,
-      const PlatformVerificationFlow::Delegate::ConsentCallback& callback);
+  PlatformVerificationDialog(content::WebContents* web_contents,
+                             const base::string16& domain,
+                             const ConsentCallback& callback);
 
   // views::DialogDelegate:
   bool Cancel() override;
   bool Accept() override;
   bool Close() override;
   base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
 
   // views::WidgetDelegate:
   ui::ModalType GetModalType() const override;
 
   // views::View:
   gfx::Size GetPreferredSize() const override;
 
   // views::StyledLabelListener:
   void StyledLabelLinkClicked(const gfx::Range& range,
                               int event_flags) override;
 
   // content::WebContentsObserver:
   void DidStartNavigationToPendingEntry(
       const GURL& url,
       content::NavigationController::ReloadType reload_type) override;
 
   base::string16 domain_;
-  PlatformVerificationFlow::Delegate::ConsentCallback callback_;
+  ConsentCallback callback_;
 
   DISALLOW_COPY_AND_ASSIGN(PlatformVerificationDialog);
 };
 
 }  // namespace attestation
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_ATTESTATION_PLATFORM_VERIFICATION_DIALOG_H_