Source/platform/graphics/ImageSource.cpp - Issue 1001703003: Take NativeImageSkia out behind the woodshed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/ImageSource.cpp

Issue 1001703003: Take NativeImageSkia out behind the woodshed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Switch to skia-style API (return bool instead of SkBitmap) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/ImageSource.cpp

diff --git a/Source/platform/graphics/ImageSource.cpp b/Source/platform/graphics/ImageSource.cpp

index e8c9ca0088d7a95f07e43ea47f20fb09fef5fbec..7fe50250be1c80711e6ead4d8f288e192dbcb9f8 100644

--- a/Source/platform/graphics/ImageSource.cpp

+++ b/Source/platform/graphics/ImageSource.cpp

@@ -107,11 +107,11 @@ size_t ImageSource::frameCount() const

return count;

}

-PassRefPtr<NativeImageSkia> ImageSource::createFrameAtIndex(size_t index)

+bool ImageSource::createFrameAtIndex(size_t index, SkBitmap* bitmap)

{

if (!m_decoder)

- return nullptr;

- return m_decoder->createFrameAtIndex(index);

+ return false;

+ return m_decoder->createFrameAtIndex(index, bitmap);

}

float ImageSource::frameDurationAtIndex(size_t index) const