Source/core/svg/graphics/SVGImageForContainer.h - Issue 1001703003: Take NativeImageSkia out behind the woodshed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/graphics/SVGImageForContainer.h

Issue 1001703003: Take NativeImageSkia out behind the woodshed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Switch to skia-style API (return bool instead of SkBitmap) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/graphics/SVGImageForContainer.h

diff --git a/Source/core/svg/graphics/SVGImageForContainer.h b/Source/core/svg/graphics/SVGImageForContainer.h

index 9bbe08a4f81dbbd1d0c12143b957f3e4dc642416..9822d9292219b3a7bc3466678e76e35209fc37d5 100644

--- a/Source/core/svg/graphics/SVGImageForContainer.h

+++ b/Source/core/svg/graphics/SVGImageForContainer.h

@@ -61,7 +61,7 @@ public:

// FIXME: Implement this to be less conservative.

virtual bool currentFrameKnownToBeOpaque() override { return false; }

- virtual PassRefPtr<NativeImageSkia> nativeImageForCurrentFrame() override;

+ virtual bool bitmapForCurrentFrame(SkBitmap*) override;

private:

SVGImageForContainer(SVGImage* image, const FloatSize& containerSize, float zoom)