Source/core/svg/graphics/filters/SVGFEImage.cpp - Issue 1001703003: Take NativeImageSkia out behind the woodshed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/graphics/filters/SVGFEImage.cpp

Issue 1001703003: Take NativeImageSkia out behind the woodshed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Make bitmapForCurrentFrame() return SkBitmap by value. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/graphics/filters/SVGFEImage.cpp

diff --git a/Source/core/svg/graphics/filters/SVGFEImage.cpp b/Source/core/svg/graphics/filters/SVGFEImage.cpp

index 9bc816ec86142b77db43d541a11fa266cd4aa239..943d1fcf4a3f10b6122845a12613ea66a8860713 100644

--- a/Source/core/svg/graphics/filters/SVGFEImage.cpp

+++ b/Source/core/svg/graphics/filters/SVGFEImage.cpp

@@ -217,11 +217,7 @@ PassRefPtr<SkImageFilter> FEImage::createImageFilter(SkiaImageFilterBuilder* bui

m_preserveAspectRatio->transformRect(dstRect, srcRect);

- if (!m_image->nativeImageForCurrentFrame())

- return adoptRef(SkBitmapSource::Create(SkBitmap()));

- RefPtr<SkImageFilter> result = adoptRef(SkBitmapSource::Create(m_image->nativeImageForCurrentFrame()->bitmap(), srcRect, dstRect));

- return result.release();

+ return adoptRef(SkBitmapSource::Create(m_image->bitmapForCurrentFrame(), srcRect, dstRect));

}

} // namespace blink