Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1001693003: Add terrible workaround to fix stencil clear crash on S3. (Closed)

Created:
5 years, 9 months ago by bsalomon
Modified:
5 years, 9 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add terrible workaround to fix stencil clear crash on S3. BUG=skia:3525 Committed: https://skia.googlesource.com/skia/+/084340bb9bbb538baf02a11ac36e29f0d9cdc493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bsalomon
I'm not happy about this workaround but it's minimally invasive and let's us move past ...
5 years, 9 months ago (2015-03-11 22:43:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001693003/1
5 years, 9 months ago (2015-03-11 22:43:55 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-11 22:43:55 UTC) #5
joshualitt
On 2015/03/11 22:43:55, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 9 months ago (2015-03-11 22:45:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/084340bb9bbb538baf02a11ac36e29f0d9cdc493
5 years, 9 months ago (2015-03-11 22:50:00 UTC) #7
bsalomon
On 2015/03/11 22:50:00, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
5 years, 9 months ago (2015-03-11 23:43:10 UTC) #8
ccameron
5 years, 9 months ago (2015-03-13 23:03:05 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1005263002/ by ccameron@chromium.org.

The reason for reverting is: Needs to be reverted in order to cleanly revert
https://codereview.chromium.org/949263002

That one needs to be reverted to fix black boxes with GPU
raster, and GPU bot failures.

BUG=466690.

Powered by Google App Engine
This is Rietveld 408576698