Add Locking calls to file_io.h plus implementations and test

util/test/thread_posix.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "util/win/time.h"
+#include "util/test/thread.h"
 
 #include "gtest/gtest.h"
+#include "util/test/errors.h"
 
 namespace crashpad {
 namespace test {
-namespace {
 
-TEST(Time, Reasonable) {
-  timeval t;
-  GetTimeOfDay(&t);
-  // Assume that time's time_t return is seconds from 1970.
-  time_t approx_now = time(nullptr);
-  EXPECT_GE(approx_now, t.tv_sec);
-  EXPECT_LT(approx_now - 100, t.tv_sec);
+void Thread::Start() {
+  EXPECT_FALSE(platform_thread_);

[Mark Mentovai, 2015/03/20 22:11:37]

ASSERT on this and the one at the top of Join(). Same in the _win.cc.

[scottmg, 2015/03/20 22:32:53]

Done.

+  int rv = pthread_create(&platform_thread_, nullptr, ThreadEntryThunk, this);
+  ASSERT_EQ(0, rv) << ErrnoMessage(rv, "pthread_create");
 }
 
-}  // namespace
+void Thread::Join() {
+  EXPECT_TRUE(platform_thread_);
+  int rv = pthread_join(platform_thread_, nullptr);
+  ASSERT_EQ(0, rv) << ErrnoMessage(rv, "pthread_join");

[Mark Mentovai, 2015/03/20 22:11:37]

EXPECT like you did in the _win.cc, so that you still zero out platform_thread_
if it was a bad thread. Or leave this at ASSERT if you like that better and let
there be another failure in the destructor. I don’t have a strong preference
between EXPECT and ASSERT for this line, but the _posix.cc and _win.cc should
match.

[scottmg, 2015/03/20 22:32:53]

Done.

+  platform_thread_ = 0;
+}
+
+// static
+void* Thread::ThreadEntryThunk(void* argument) {
+  Thread* self = reinterpret_cast<Thread*>(argument);
+  self->Main();
+  return nullptr;
+}
+
 }  // namespace test
 }  // namespace crashpad