Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1001613002: Use path in name for test262-es6 (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use path in name for test262-es6 For ES5 the file names always included the whole path, like this: ch15/15.2/15.2.3/15.2.3.14/15.2.3.14-1-3.js For ES6 this is no longer true: language/computed-property-names/basics/symbol.js language/computed-property-names/class/method/symbol.js To allow the status file to correctly identify the right test we need to change the reported test name to include the whole path. BUG=None LOG=N R=rossberg@chromium.org, machenbach@chromium.org Committed: https://crrev.com/36df5747bf12d82f206bcc1ca7d743843d8869fc Cr-Commit-Position: refs/heads/master@{#27167}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove method override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -101 lines) Patch
M test/test262-es6/test262-es6.status View 2 chunks +98 lines, -98 lines 0 comments Download
M test/test262-es6/testcfg.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 9 months ago (2015-03-11 19:56:06 UTC) #1
Jakob Kummerow
DBC https://codereview.chromium.org/1001613002/diff/1/test/test262-es6/testcfg.py File test/test262-es6/testcfg.py (right): https://codereview.chromium.org/1001613002/diff/1/test/test262-es6/testcfg.py#newcode60 test/test262-es6/testcfg.py:60: def CommonTestName(self, testcase): Just drop the method definition ...
5 years, 9 months ago (2015-03-11 21:14:10 UTC) #2
arv (Not doing code reviews)
Remove method override
5 years, 9 months ago (2015-03-11 21:19:37 UTC) #3
arv (Not doing code reviews)
https://codereview.chromium.org/1001613002/diff/1/test/test262-es6/testcfg.py File test/test262-es6/testcfg.py (right): https://codereview.chromium.org/1001613002/diff/1/test/test262-es6/testcfg.py#newcode60 test/test262-es6/testcfg.py:60: def CommonTestName(self, testcase): On 2015/03/11 21:14:10, Jakob wrote: > ...
5 years, 9 months ago (2015-03-11 21:20:33 UTC) #4
rossberg
lgtm
5 years, 9 months ago (2015-03-12 08:32:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001613002/20001
5 years, 9 months ago (2015-03-12 16:15:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-12 16:36:22 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 16:36:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36df5747bf12d82f206bcc1ca7d743843d8869fc
Cr-Commit-Position: refs/heads/master@{#27167}

Powered by Google App Engine
This is Rietveld 408576698