content/browser/renderer_host/render_widget_host_view_android.h - Issue 1001573003: [Android] Stop hiding the RWHV layer subtree when hiding the widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 1001573003: [Android] Stop hiding the RWHV layer subtree when hiding the widget (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/delegated_frame_evictor.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index e6d85b93313220ae0686eecfbdc6c2a6aefbc7ea..fe1ea3eb21998c5f36e7387799230a53e5c6f848 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -175,11 +175,14 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

// ui::WindowAndroidObserver implementation.

void OnCompositingDidCommit() override;

+ void OnRootWindowVisibilityChanged(bool visible) override;

void OnAttachCompositor() override;

void OnDetachCompositor() override;

void OnVSync(base::TimeTicks frame_time,

base::TimeDelta vsync_period) override;

void OnAnimate(base::TimeTicks begin_frame_time) override;

+ void OnActivityPaused() override;

+ void OnActivityResumed() override;

// DelegatedFrameEvictor implementation

void EvictDelegatedFrame() override;

@@ -269,6 +272,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

const cc::CompositorFrameMetadata& frame_metadata);

void ComputeContentsSize(const cc::CompositorFrameMetadata& frame_metadata);

+ void ShowInternal();

+ void HideInternal(bool hide_frontbuffer, bool stop_observing_root_window);

void AttachLayers();

void RemoveLayers();