chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java - Issue 1001573003: [Android] Stop hiding the RWHV layer subtree when hiding the widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

Issue 1001573003: [Android] Stop hiding the RWHV layer subtree when hiding the widget (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/TabTest.java ('k') | content/browser/renderer_host/compositor_impl_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

index b17e47a882b81b70745ba5791cfa6d9120f1b63b..3b451ab474ece03149e3d484d2e414ffe32b1857 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

@@ -83,7 +83,8 @@ public class ChromeShellActivity extends AppCompatActivity implements AppMenuPro

new ActivityWindowAndroidFactory() {

@Override

public ActivityWindowAndroid getActivityWindowAndroid(Activity activity) {

- return new ActivityWindowAndroid(activity);

+ final boolean listenToActivityState = true;

+ return new ActivityWindowAndroid(activity, listenToActivityState);

}

};

@@ -278,9 +279,6 @@ public class ChromeShellActivity extends AppCompatActivity implements AppMenuPro

super.onStop();

if (mToolbar != null) mToolbar.hideSuggestions();

- Tab activeTab = getActiveTab();

- if (activeTab != null) activeTab.onActivityStop();

}

@Override