Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1001563003: Fix in multi-package-resolver to support files that will be created later (graph (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix in multi-package-resolver to support files that will be created later (graph assumes the Source class exists, even when the file has not been created, we consider that by default the file will be created on the location for the first of the searchPaths) R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/07590c234a18091d094d9fb4b7b091257f1f5d73

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -30 lines) Patch
M lib/src/dependency_graph.dart View 1 7 chunks +46 lines, -26 lines 0 comments Download
M lib/src/testing.dart View 1 3 chunks +9 lines, -4 lines 0 comments Download
M test/dependency_graph_test.dart View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-11 20:03:56 UTC) #3
vsm
lgtm https://codereview.chromium.org/1001563003/diff/20001/lib/src/checker/multi_package_resolver.dart File lib/src/checker/multi_package_resolver.dart (right): https://codereview.chromium.org/1001563003/diff/20001/lib/src/checker/multi_package_resolver.dart#newcode29 lib/src/checker/multi_package_resolver.dart:29: // prefix. The returned source will have that ...
5 years, 9 months ago (2015-03-11 20:07:51 UTC) #4
Siggi Cherem (dart-lang)
ptal https://codereview.chromium.org/1001563003/diff/20001/lib/src/checker/multi_package_resolver.dart File lib/src/checker/multi_package_resolver.dart (right): https://codereview.chromium.org/1001563003/diff/20001/lib/src/checker/multi_package_resolver.dart#newcode29 lib/src/checker/multi_package_resolver.dart:29: // prefix. The returned source will have that ...
5 years, 9 months ago (2015-03-12 18:26:40 UTC) #5
vsm
lgtm
5 years, 9 months ago (2015-03-12 18:30:53 UTC) #6
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-12 19:50:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
07590c234a18091d094d9fb4b7b091257f1f5d73 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698