content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 1001553004: Fix race condition between attaching and destruction of native IME object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1001553004: Fix race condition between attaching and destruction of native IME object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments about separate Dismiss class Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index ac9c104186399a21c227fb973109ff9a09f1d04f..268d9ee0bea1214e98017faa49ff65ee15c02830 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1558,8 +1558,7 @@ public class ContentViewCore

if (newConfig.keyboard != Configuration.KEYBOARD_NOKEYS) {

if (mNativeContentViewCore != 0) {

- mImeAdapter.attach(nativeGetNativeImeAdapter(mNativeContentViewCore),

- TextInputType.NONE, 0 /* no flags */);

+ mImeAdapter.attach(nativeGetNativeImeAdapter(mNativeContentViewCore));

}

mInputMethodManagerWrapper.restartInput(mContainerView);

}