testing/scripts/gtest_perf_test.py - Issue 1001533003: Always add test-type argument to runtest.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/scripts/gtest_perf_test.py

Issue 1001533003: Always add test-type argument to runtest.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only add test-type once Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/scripts/gtest_perf_test.py

diff --git a/testing/scripts/gtest_perf_test.py b/testing/scripts/gtest_perf_test.py

index 5518cb1cb2a3ca6fcf25be5aa082ae930979e9ab..b490f058c4ed4229b9ef16682ecaa535f51aa3f6 100755

--- a/testing/scripts/gtest_perf_test.py

+++ b/testing/scripts/gtest_perf_test.py

@@ -31,6 +31,7 @@ def main_run(args):

'--builder-name', args.properties.get('buildername'),

'--build-number', str(args.properties.get('buildnumber')),

'--log-processor-output-file', tempfile_path,

+ '--test-type', test_suite,

]

if 'android' == args.properties.get('target_platform'):

@@ -43,7 +44,6 @@ def main_run(args):

'--verbose',

])

else:

- gtest_args.extend(['--xvfb', '--test-type', test_suite])

qyearsley 2015/03/11 17:44:58 --xvfb isn't required in the case of non-android n

sullivan 2015/03/11 17:47:21 Whoops, only meant to remove --test-type. Fixed in

gtest_args.extend(script_args)

rc = common.run_runtest(args, gtest_args + filter_tests)

« no previous file with comments | « no previous file | no next file » | no next file with comments »