Always add test-type argument to runtest.py

Add test-type argument to runtest.py

This argument is used to identify the correct test suite when uploading perf dashboard data from gTests.

BUG=466110
Committed: https://crrev.com/be01902b3c24600f4b20d53b5fbad802e3aa2740
Cr-Commit-Position: refs/heads/master@{#320115}

[sullivan, 2015-03-11 15:32:29]

sullivan@chromium.org changed reviewers:
+ iannucci@chromium.org, phajdan.jr@chromium.org, simonhatch@chromium.org

[shatch, 2015-03-11 15:35:23]

https://codereview.chromium.org/1001533003/diff/1/testing/scripts/gtest_perf_...
File testing/scripts/gtest_perf_test.py (right):

https://codereview.chromium.org/1001533003/diff/1/testing/scripts/gtest_perf_...
testing/scripts/gtest_perf_test.py:47: gtest_args.extend(['--xvfb',
'--test-type', test_suite])
Should you remove this --test-type if you added it above?

[sullivan, 2015-03-11 15:42:35]

https://codereview.chromium.org/1001533003/diff/1/testing/scripts/gtest_perf_...
File testing/scripts/gtest_perf_test.py (right):

https://codereview.chromium.org/1001533003/diff/1/testing/scripts/gtest_perf_...
testing/scripts/gtest_perf_test.py:47: gtest_args.extend(['--xvfb',
'--test-type', test_suite])
On 2015/03/11 15:35:23, shatch wrote:
> Should you remove this --test-type if you added it above?

Whoops, missed that! Fixed.

[shatch, 2015-03-11 15:43:46]

On 2015/03/11 15:42:35, sullivan wrote:
>
https://codereview.chromium.org/1001533003/diff/1/testing/scripts/gtest_perf_...
> File testing/scripts/gtest_perf_test.py (right):
> 
>
https://codereview.chromium.org/1001533003/diff/1/testing/scripts/gtest_perf_...
> testing/scripts/gtest_perf_test.py:47: gtest_args.extend(['--xvfb',
> '--test-type', test_suite])
> On 2015/03/11 15:35:23, shatch wrote:
> > Should you remove this --test-type if you added it above?
> 
> Whoops, missed that! Fixed.

lg2m

[sullivan, 2015-03-11 16:05:22]

Robbie, Pawel, can either of you do an OWNERS review?

[qyearsley, 2015-03-11 17:44:58]

qyearsley@chromium.org changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2015-03-11 17:44:58]

https://codereview.chromium.org/1001533003/diff/20001/testing/scripts/gtest_p...
File testing/scripts/gtest_perf_test.py (left):

https://codereview.chromium.org/1001533003/diff/20001/testing/scripts/gtest_p...
testing/scripts/gtest_perf_test.py:46: gtest_args.extend(['--xvfb',
'--test-type', test_suite])
--xvfb isn't required in the case of non-android now?

[sullivan, 2015-03-11 17:47:21]

https://codereview.chromium.org/1001533003/diff/20001/testing/scripts/gtest_p...
File testing/scripts/gtest_perf_test.py (left):

https://codereview.chromium.org/1001533003/diff/20001/testing/scripts/gtest_p...
testing/scripts/gtest_perf_test.py:46: gtest_args.extend(['--xvfb',
'--test-type', test_suite])
On 2015/03/11 17:44:58, qyearsley wrote:
> --xvfb isn't required in the case of non-android now?

Whoops, only meant to remove --test-type. Fixed in new patchset.

[qyearsley, 2015-03-11 17:49:43]

LGTM; now waiting for OWNERS review I think?

[iannucci, 2015-03-11 17:52:58]

lgtm. IIUC, this doesn't change the interface of this script, just how it calls
runtest?

[sullivan, 2015-03-11 17:54:15]

On 2015/03/11 17:52:58, iannucci wrote:
> lgtm. IIUC, this doesn't change the interface of this script, just how it
calls
> runtest?

yes.

[sullivan, 2015-03-11 17:54:19]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2015-03-11 17:54:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1001533003/40001

[commit-bot: I haz the power, 2015-03-11 18:39:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-11 18:40:26]

Patchset 3 (id:??) landed as
https://crrev.com/be01902b3c24600f4b20d53b5fbad802e3aa2740
Cr-Commit-Position: refs/heads/master@{#320115}