Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1001533002: Vector-ICs: Implement slot sharing for global loads. (Closed)

Created:
5 years, 9 months ago by mvstanton
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@vector-christmas
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Vector-ICs: Implement slot sharing for global loads. We can reduce the number of type feedback vector slots required, and also reduce IC misses. Committed: https://crrev.com/4ededa8694c489b07334bb44d1186726b260bd81 Cr-Commit-Position: refs/heads/master@{#27149}

Patch Set 1 #

Patch Set 2 : Added test, refactoring. #

Patch Set 3 : Removed flag. #

Patch Set 4 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -23 lines) Patch
M src/ast.h View 1 2 3 10 chunks +42 lines, -20 lines 0 comments Download
M src/ast.cc View 1 2 chunks +31 lines, -1 line 0 comments Download
M src/ast-numbering.cc View 1 2 3 3 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mvstanton
Hi Toon, I hope not to overload you, if you'd like to suggest a different ...
5 years, 9 months ago (2015-03-11 15:55:17 UTC) #2
Toon Verwaest
lgtm
5 years, 9 months ago (2015-03-11 17:58:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001533002/60001
5 years, 9 months ago (2015-03-12 09:12:04 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-12 09:22:51 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 09:23:09 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4ededa8694c489b07334bb44d1186726b260bd81
Cr-Commit-Position: refs/heads/master@{#27149}

Powered by Google App Engine
This is Rietveld 408576698