Implement support for mixed sampled render targets

include/gpu/GrRenderTarget.h

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrRenderTarget_DEFINED
 #define GrRenderTarget_DEFINED
 
@@ skipping 13 matching lines @@
 class GrRenderTarget : virtual public GrSurface {
 public:
     SK_DECLARE_INST_COUNT(GrRenderTarget)
 
     // GrSurface overrides
     GrRenderTarget* asRenderTarget() override { return this; }
     const GrRenderTarget* asRenderTarget() const  override { return this; }
 
     // GrRenderTarget
     /**
-     * @return true if the surface is multisampled, false otherwise
+     * On some hardware it is possible for a render target to have multisampling
+     * only in certain buffers. This enum allows the caller to query about
+     * specific buffers in isMultisampled() and numSamples().
      */
-    bool isMultisampled() const { return 0 != fDesc.fSampleCnt; }
+    enum BufferBits {
+        kAny_BufferBits = 0,
+        kColor_BufferBit = 1,
+        kStencil_BufferBit = (1 << 1),
+        kAll_BufferBits = kColor_BufferBit + kStencil_BufferBit
+    };
 
     /**
-     * @return the number of samples-per-pixel or zero if non-MSAA.
+     * Enforce only two legal sample configs.
+     * kUnified_SampleConfig signifies multisampling in both color and stencil
+     * buffers and is available across all hardware.
+     * kStencil_SampleConfig means multisampling is present in stencil buffer
+     * only; this config requires hardware support of
+     * NV_framebuffer_mixed_samples.
+    */
+    enum SampleConfig {
+        kUnified_SampleConfig = kColor_BufferBit + kStencil_BufferBit,
+        kStencil_SampleConfig = kStencil_BufferBit
+    };
+
+    /**
+     * @param  buffers  specifies the buffers for which multisampling is queried
+     * @return true if the surface is multisampled in the specified buffer(s),

[Chris Dalton, 2015/04/07 23:48:23]

Nit picking, but this is maybe ambiguous. How about:

"@return true if the surface is multisampled in every specified buffer"

[vbuzinov, 2015/04/08 12:05:30]

Done.

+     *         false otherwise
      */
-    int numSamples() const { return fDesc.fSampleCnt; }
+    bool isMultisampled(BufferBits buffers = kAll_BufferBits) const {
+        if (buffers != (fSampleConfig & buffers)) {
+            // One of the buffers is not in our msaa config.
+            return false;
+        }
+        return 0 != fDesc.fSampleCnt;
+    }
+
+    /**
+     * @param  buffers  specifies the buffers for which multisampling is queried
+     * @return the number of samples-per-pixel, or zero if the render target
+     *         is not multisampled in the specified buffer(s)

[Chris Dalton, 2015/04/07 23:48:23]

Here too:

"@return the number of samples-per-pixel, or zero if any of the specified
buffers is not multisampled."

[vbuzinov, 2015/04/08 12:05:30]

Done.

+     */
+    int numSamples(BufferBits buffers = kAll_BufferBits) const {
+        return this->isMultisampled(buffers) ? fDesc.fSampleCnt : 0;
+    }
+
+    /**
+     * @return sample config: kUnified_SampleConfig if both color and stencil
+               buffers are MSAA, or kStencil_SampleConfig if only stencil
+               buffer is MSAA.
+     */
+    SampleConfig sampleConfig() const {
+        return fSampleConfig;
+    }
 
     /**
      * Call to indicate the multisample contents were modified such that the
      * render target needs to be resolved before it can be used as texture. Gr
      * tracks this for its own drawing and thus this only needs to be called
      * when the render target has been modified outside of Gr. This has no
      * effect on wrapped backend render targets.
      *
      * @param rect  a rect bounding the area needing resolve. NULL indicates
      *              the whole RT needs resolving.
@@ skipping 35 matching lines @@
         kAutoResolves_ResolveType,
         kCantResolve_ResolveType,
     };
     virtual ResolveType getResolveType() const = 0;
 
     // Provides access to functions that aren't part of the public API.
     GrRenderTargetPriv renderTargetPriv();
     const GrRenderTargetPriv renderTargetPriv() const;
 
 protected:
-    GrRenderTarget(GrGpu* gpu, LifeCycle lifeCycle, const GrSurfaceDesc& desc)
+    GrRenderTarget(GrGpu* gpu, LifeCycle lifeCycle, const GrSurfaceDesc& desc,
+                   SampleConfig sampleConfig)
         : INHERITED(gpu, lifeCycle, desc)
+        , fSampleConfig(sampleConfig)
         , fStencilBuffer(NULL) {
         fResolveRect.setLargestInverted();
     }
 
     // override of GrResource
     void onAbandon() override;
     void onRelease() override;
 
 private:
     // Checked when this object is asked to attach a stencil buffer.
     virtual bool canAttemptStencilAttachment() const = 0;
 
     friend class GrRenderTargetPriv;
 
+    SampleConfig      fSampleConfig;
+
     GrStencilBuffer*  fStencilBuffer;
 
     SkIRect           fResolveRect;
 
     typedef GrSurface INHERITED;
 };
 
+GR_MAKE_BITFIELD_OPS(GrRenderTarget::BufferBits)
+
 #endif