Implement support for mixed sampled render targets

include/gpu/GrRenderTarget.h

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrRenderTarget_DEFINED
 #define GrRenderTarget_DEFINED
 
@@ skipping 13 matching lines @@
 class GrRenderTarget : virtual public GrSurface {
 public:
     SK_DECLARE_INST_COUNT(GrRenderTarget)
 
     // GrSurface overrides
     GrRenderTarget* asRenderTarget() SK_OVERRIDE { return this; }
     const GrRenderTarget* asRenderTarget() const  SK_OVERRIDE { return this; }
 
     // GrRenderTarget
     /**
-     * @return true if the surface is multisampled, false otherwise
+     * Pipeline stage serves as a query parameter to render target's isMultisampled
+     * and numSamples methods.  It signifies whether the caller is interested in
+     * multisampling in color buffer or stencil buffer specifically, both, or any of
+     * the two.  Used by the NV_framebuffer_mixed_samples implementation.

[Chris Dalton, 2015/03/20 07:01:45]

This comment should probably talk about the pipeline stage instead of the
buffer. I might reword it something like this:

"On some hardware it is possible for a render target to have multisampling only
in certain stages of the graphics pipeline. This enum allows the caller to query
about specific stages in isMultisampled() and numSamples()."

      */
-    bool isMultisampled() const { return 0 != fDesc.fSampleCnt; }
+    enum PipelineStage {
+        kColorBuffer_PipelineStage,
+        kStencilBuffer_PipelineStage,

[Chris Dalton, 2015/03/20 07:01:45]

These equalities seem like they need a comment.

 // We only support two sample configs at the moment, unified and stencil. So we
can query multisample info for everywhere/anywhere by checking the correct
buffer.

+        kEverywhere_PipelineStage = kColorBuffer_PipelineStage,
+        kAnywhere_PipelineStage = kStencilBuffer_PipelineStage
+    };
 
     /**
-     * @return the number of samples-per-pixel or zero if non-MSAA.
+     * @param  pipelineStage  specifies the pipeline stage for which
+     *                        multisampling is queried
+     * @return true if the surface is multisampled in all of the buffers
+     *         specified by the sample config, false if any are non-MSAA

[Chris Dalton, 2015/03/20 07:01:45]

"true if the surface is multisampled in the specified pipeline stage(s), false
otherwise"

      */
-    int numSamples() const { return fDesc.fSampleCnt; }
+    bool isMultisampled(PipelineStage pipelineStage =
+                                      kEverywhere_PipelineStage) const {
+        return 0 != numSamples(pipelineStage);
+    }
+
+    /**
+     * @param  pipelineStage  specifies the pipeline stage for which
+     *                        multisampling is queried
+     * @return the number of samples-per-pixel or zero if any of the specified
+     *         buffers is non-MSAA.

[Chris Dalton, 2015/03/20 07:01:45]

"the number of samples-per-pixel, or zero if the render target is not
multisampled in the specified pipeline stage(s)"

+     */
+    int numSamples(PipelineStage pipelineStage =
+                                 kEverywhere_PipelineStage) const {

[Chris Dalton, 2015/03/20 07:01:45]

Now I'm nit-picking, but I'm wondering if this function could be more clear if
it were implemented in this way?

  return this->isMultisampled(pipelineStage) ? fDesc.fSampleCnt : 0;

Then isMultisampled would obviously be the one to check fSampleConfig instead:

 if (kStencil_GrSampleConfig == fSampleConfig &&
     kColorBuffer_PipelineStage == pipelineStage) {
     return false;
 }
 return 0 != fDesc.fSampleCnt;

Thoughs? This way seems more natural to me at the moment...

+        if (kStencil_GrSampleConfig == fSampleConfig &&
+            kColorBuffer_PipelineStage == pipelineStage) {
+            return 0;
+        }
+        return fDesc.fSampleCnt;
+    }
+
+    /**
+     * @return sample config: kUnified_GrSampleConfig if both color and stencil
+               buffers are MSAA, or kStencil_GrSampleConfig if only stencil
+               buffer is MSAA.
+     */
+    GrSampleConfig sampleConfig() const {
+        return fSampleConfig;
+    }
 
     /**
      * Call to indicate the multisample contents were modified such that the
      * render target needs to be resolved before it can be used as texture. Gr
      * tracks this for its own drawing and thus this only needs to be called
      * when the render target has been modified outside of Gr. This has no
      * effect on wrapped backend render targets.
      *
      * @param rect  a rect bounding the area needing resolve. NULL indicates
      *              the whole RT needs resolving.
@@ skipping 35 matching lines @@
         kAutoResolves_ResolveType,
         kCantResolve_ResolveType,
     };
     virtual ResolveType getResolveType() const = 0;
 
     // Provides access to functions that aren't part of the public API.
     GrRenderTargetPriv renderTargetPriv();
     const GrRenderTargetPriv renderTargetPriv() const;
 
 protected:
-    GrRenderTarget(GrGpu* gpu, LifeCycle lifeCycle, const GrSurfaceDesc& desc)
+    GrRenderTarget(GrGpu* gpu, LifeCycle lifeCycle, const GrSurfaceDesc& desc,
+                   GrSampleConfig sampleConfig)
         : INHERITED(gpu, lifeCycle, desc)
+        , fSampleConfig(sampleConfig)
         , fStencilBuffer(NULL) {
         fResolveRect.setLargestInverted();
     }
 
     // override of GrResource
     void onAbandon() SK_OVERRIDE;
     void onRelease() SK_OVERRIDE;
 
 private:
     // Checked when this object is asked to attach a stencil buffer.
     virtual bool canAttemptStencilAttachment() const = 0;
 
     friend class GrRenderTargetPriv;
 
+    GrSampleConfig    fSampleConfig;
+
     GrStencilBuffer*  fStencilBuffer;
 
     SkIRect           fResolveRect;
 
     typedef GrSurface INHERITED;
 };
 
 #endif