Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1001453006: Add Load2/store2 to Sk4x (dumb impl for now) (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Load2/store2 to Sk4x (dumb impl for now) patch from issue 1001003002 at patchset 1 (http://crrev.com/1001003002#ps1) BUG=skia: Committed: https://skia.googlesource.com/skia/+/422677ceab3908060917adf4181aaebb48bbaf41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/core/Sk4x.h View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/Sk4xTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reed1
can I land this, and then we back-fill with "faster" impls later?
5 years, 9 months ago (2015-03-18 19:47:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001453006/1
5 years, 9 months ago (2015-03-18 19:48:04 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-18 19:48:05 UTC) #5
msarett
lgtm Mike had a CL that implemented Load2/Store2 for SSE that I gave an lgtm. ...
5 years, 9 months ago (2015-03-18 19:56:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/422677ceab3908060917adf4181aaebb48bbaf41
5 years, 9 months ago (2015-03-18 19:56:50 UTC) #7
mtklein
Right, the one I sent out will be faster, but this is fine to start ...
5 years, 9 months ago (2015-03-18 19:57:26 UTC) #8
reed1
5 years, 9 months ago (2015-03-18 20:44:27 UTC) #9
Message was sent while issue was closed.
On 2015/03/18 19:57:26, mtklein wrote:
> Right, the one I sent out will be faster, but this is fine to start with if
you
> just want to get an API settled.

exactly, I wanted to have the api available for use-case testing.

Powered by Google App Engine
This is Rietveld 408576698