Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 100143006: Added a test for destroying an isolate while a timer is outstanding. (Closed)

Created:
7 years ago by Aaron Boodman
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Added a test for destroying an isolate while a timer is outstanding. Cleaned up a few of the existing tests. BUG= R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243185

Patch Set 1 #

Patch Set 2 : yo #

Patch Set 3 : remove old comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -47 lines) Patch
M gin/modules/timer.cc View 1 4 chunks +10 lines, -3 lines 0 comments Download
M gin/modules/timer_unittest.cc View 1 2 4 chunks +76 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Aaron Boodman
7 years ago (2013-12-21 23:38:28 UTC) #1
abarth-chromium
LGTM Thanks for following through with a test!
7 years ago (2013-12-22 01:29:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/100143006/120001
7 years ago (2013-12-22 06:15:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=239613
7 years ago (2013-12-22 08:21:01 UTC) #4
Aaron Boodman
6 years, 11 months ago (2014-01-06 22:23:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r243185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698