Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1001373002: Organize sky/framework/animation (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
rafaelw, eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Organize sky/framework/animation This CL cleans up the sky/framework/animation as follows: 1) I've moved code that's used only by the custom elements framework into sky/framework/elements/animation. This code is based on AnimationDelegates rather than Streams. 2) Rename ScrollCurve to ScrollBehavior because it encapsulates more behavior than just a curve. 3) Make the Generator interface explicit and mark subclasses as actual subclasses. 4) Move Simulation into generators.dart because it implements the Generator interface. 5) Move Animation out of generators.dart because it does not implement the Generator interface. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8907320aca357cb0f7b062ed2d04bf7c772c9f47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -421 lines) Patch
M sky/examples/stocks-fn/stocklist.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks-fn/stocksapp.dart View 1 chunk +1 line, -1 line 0 comments Download
A sky/framework/animation/animation.dart View 1 chunk +54 lines, -0 lines 0 comments Download
D sky/framework/animation/controller.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/framework/animation/generator.dart View 1 chunk +0 lines, -155 lines 0 comments Download
A + sky/framework/animation/generators.dart View 3 chunks +36 lines, -40 lines 0 comments Download
A + sky/framework/animation/scroll_behavior.dart View 3 chunks +8 lines, -8 lines 0 comments Download
D sky/framework/animation/scroll_curve.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/framework/animation/simulation.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/framework/animation/timer.dart View 1 chunk +0 lines, -51 lines 0 comments Download
M sky/framework/components/drawer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/fixed_height_scrollable.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/framework/components/ink_splash.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/scrollable.dart View 4 chunks +6 lines, -7 lines 0 comments Download
A + sky/framework/elements/animation/controller.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/framework/elements/animation/timer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/framework/elements/sky-drawer.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-13 16:55:06 UTC) #2
eseidel
lgtm
5 years, 9 months ago (2015-03-13 17:02:59 UTC) #3
abarth-chromium
5 years, 9 months ago (2015-03-13 17:05:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8907320aca357cb0f7b062ed2d04bf7c772c9f47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698