Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4280)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java

Issue 1001343002: Prefetch the native library from native code by parsing /proc/pid/maps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/android/library_loader/library_prefetcher.cc ('K') | « base/base.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java b/chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java
index 57f3e28af0ecff236f221d8efd23699cfdc31fcf..3f6ba4d08c78c3c8c506851f13da856b505256be 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java
@@ -91,7 +91,7 @@ class NativeInitializationController {
// generally startup on some devices, most likely by
// competing for IO.
// For experimental results, see http://crbug.com/460438.
- libraryLoader.asyncPrefetchLibrariesToMemory(mContext);
rmcilroy 2015/03/24 15:18:26 Can we delete asyncPrefetchLibrariesToMemory from
Benoit L 2015/03/25 10:36:19 Can we keep it as a fallback for now, in case some
rmcilroy 2015/03/25 15:12:18 Are you meaning fallback as in keep the code aroun
+ LibraryLoader.nativeForkAndPrefetchNativeLibrary();
} catch (ProcessInitException e) {
Log.e(TAG, "Unable to load native library.", e);
mActivityDelegate.onStartupFailure();
« base/android/library_loader/library_prefetcher.cc ('K') | « base/base.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698