Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java

Issue 1001343002: Prefetch the native library from native code by parsing /proc/pid/maps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
diff --git a/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java b/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
index 484c6bc56d55596cdf77610e3cbf8e541c4d3d67..bff9b9e638e009795dc58d54f8d020ce9fd8d315 100644
--- a/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
+++ b/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
@@ -573,4 +573,10 @@ public class LibraryLoader {
// Get the version of the native library. This is needed so that we can check we
// have the right version before initializing the (rest of the) JNI.
private native String nativeGetVersionNumber();
+
+ // Finds the ranges corresponding to the native library pages, and forks a
petrcermak 2015/03/23 15:00:47 I would say "... and then forks ..." to be a littl
petrcermak 2015/03/23 15:00:47 nit: There shouldn't be a comma after "and".
Benoit L 2015/03/23 16:41:57 Done.
Benoit L 2015/03/23 16:41:58 Done.
+ // new process to prefetch these pages. The process then terminates. Note
petrcermak 2015/03/23 15:00:47 I'd say "The new process..." to make it clear whic
Benoit L 2015/03/23 16:41:57 Done.
+ // that getting the ranges involves file operations in /proc/ and is done in
+ // the calling thread.
petrcermak 2015/03/23 15:00:47 I would add "of the original process" after "calli
Benoit L 2015/03/23 16:41:57 Done.
+ public static native void nativeForkAndPrefetchNativeLibrary();
}
« no previous file with comments | « no previous file | base/android/library_loader/library_loader_hooks.cc » ('j') | base/android/library_loader/library_prefetcher.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698