Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1001333003: Introduce window.internals.selected{Html,Text}ForClipboard() (Closed)

Created:
5 years, 9 months ago by yosin_UTC9
Modified:
5 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce window.internals.selected{HTML,Text}ForClipboard() This patch introduces |window.internals.selected{HTML,Text}ForClipboard()| for ease of writing test scripts for HTML/text serialization functionality in layout tests and make these tests independent from Clipboard API and "paste" event handlers. After this patch, we can utilize "--expose-internals-for-testing" in content shell for writing test scripts of HTML/text serialization. This patch is result of collaboration with hajimehoshi@chromium.org BUG=275851 TEST=n/a; This patch doesn't change behavior. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192058

Patch Set 1 : 2015-03-17T18:33:35 #

Total comments: 2

Patch Set 2 : 2015-03-18T10:45:03 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M Source/core/testing/Internals.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yosin_UTC9
PTAL
5 years, 9 months ago (2015-03-17 12:44:57 UTC) #3
tkent
https://codereview.chromium.org/1001333003/diff/20001/Source/core/testing/Internals.h File Source/core/testing/Internals.h (right): https://codereview.chromium.org/1001333003/diff/20001/Source/core/testing/Internals.h#newcode344 Source/core/testing/Internals.h:344: String Internals::selectedHTMLForClipboard(); Remove "Internals::"
5 years, 9 months ago (2015-03-17 22:34:19 UTC) #4
yosin_UTC9
PTAL https://codereview.chromium.org/1001333003/diff/20001/Source/core/testing/Internals.h File Source/core/testing/Internals.h (right): https://codereview.chromium.org/1001333003/diff/20001/Source/core/testing/Internals.h#newcode344 Source/core/testing/Internals.h:344: String Internals::selectedHTMLForClipboard(); On 2015/03/17 22:34:19, tkent wrote: > ...
5 years, 9 months ago (2015-03-18 02:05:04 UTC) #5
tkent
lgtm
5 years, 9 months ago (2015-03-18 02:07:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001333003/40001
5 years, 9 months ago (2015-03-18 02:08:02 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 04:04:08 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192058

Powered by Google App Engine
This is Rietveld 408576698