Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1001323002: Implement TDZ in StoreIC for top-level lexicals. (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement TDZ in StoreIC for top-level lexicals. StoreIC::Store was missing a check present in LoadIC::Load. R=rossberg@chromium.org BUG=v8:3941 LOG=Y Committed: https://crrev.com/de8e2be875bff9473c616af5e7b17d815699d44a Cr-Commit-Position: refs/heads/master@{#27182}

Patch Set 1 #

Patch Set 2 : Stupid typo #

Patch Set 3 : Hydrogen fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -1 line) Patch
M src/hydrogen.cc View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-decls.cc View 1 2 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 9 months ago (2015-03-13 10:32:57 UTC) #1
rossberg
lgtm
5 years, 9 months ago (2015-03-13 10:39:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001323002/1
5 years, 9 months ago (2015-03-13 11:43:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/810)
5 years, 9 months ago (2015-03-13 11:51:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001323002/20001
5 years, 9 months ago (2015-03-13 12:18:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/815)
5 years, 9 months ago (2015-03-13 12:31:28 UTC) #11
Dmitry Lomov (no reviews)
PTAL. The check was missing in Crankshaft as well + a bug in LoadIC::Load.
5 years, 9 months ago (2015-03-13 12:53:23 UTC) #12
rossberg
lgtm
5 years, 9 months ago (2015-03-13 12:57:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001323002/40001
5 years, 9 months ago (2015-03-13 12:57:48 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-13 13:28:11 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 13:28:27 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/de8e2be875bff9473c616af5e7b17d815699d44a
Cr-Commit-Position: refs/heads/master@{#27182}

Powered by Google App Engine
This is Rietveld 408576698