Remove hardware check that enables always-on hotwording.

Remove hardware check that enables always-on hotwording.

BUG=466907
Committed: https://crrev.com/61e6a0aa8c59a150474ba06f14ae4aa8521e4d5b
Cr-Commit-Position: refs/heads/master@{#320646}

[Anand Mistry (off Chromium), 2015-03-13 06:13:59]

amistry@chromium.org changed reviewers:
+ kcarattini@chromium.org, thestig@chromium.org

[Anand Mistry (off Chromium), 2015-03-13 06:14:00]

thestig: For OWNERS.

[Lei Zhang, 2015-03-13 06:19:32]

lgtm

https://codereview.chromium.org/1001283002/diff/1/chrome/browser/search/hotwo...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/1001283002/diff/1/chrome/browser/search/hotwo...
chrome/browser/search/hotword_service_factory.cc:50: // Temporarily disabling
hotword hardware check for M42. Will be
If you are not sure what milestone the feature will be ready in, consider
changing it so that this feature is only enabled on dev/canary channel. When the
feature is ready, remove the channel check. That way you don't have to do ToT
commit + merge + ToT revert for every milestone.

[kcarattini, 2015-03-13 06:24:42]

lgtm

[Anand Mistry (off Chromium), 2015-03-13 06:26:03]

https://codereview.chromium.org/1001283002/diff/1/chrome/browser/search/hotwo...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/1001283002/diff/1/chrome/browser/search/hotwo...
chrome/browser/search/hotword_service_factory.cc:50: // Temporarily disabling
hotword hardware check for M42. Will be
On 2015/03/13 06:19:32, Lei Zhang wrote:
> If you are not sure what milestone the feature will be ready in, consider
> changing it so that this feature is only enabled on dev/canary channel. When
the
> feature is ready, remove the channel check. That way you don't have to do ToT
> commit + merge + ToT revert for every milestone.

Hm, how do you do that?

[Lei Zhang, 2015-03-13 06:48:00]

On 2015/03/13 06:26:03, Anand Mistry wrote:
>
https://codereview.chromium.org/1001283002/diff/1/chrome/browser/search/hotwo...
> File chrome/browser/search/hotword_service_factory.cc (right):
> 
>
https://codereview.chromium.org/1001283002/diff/1/chrome/browser/search/hotwo...
> chrome/browser/search/hotword_service_factory.cc:50: // Temporarily disabling
> hotword hardware check for M42. Will be
> On 2015/03/13 06:19:32, Lei Zhang wrote:
> > If you are not sure what milestone the feature will be ready in, consider
> > changing it so that this feature is only enabled on dev/canary channel. When
> the
> > feature is ready, remove the channel check. That way you don't have to do
ToT
> > commit + merge + ToT revert for every milestone.
> 
> Hm, how do you do that?

chrome::VersionInfo::GetChannel()

[Anand Mistry (off Chromium), 2015-03-14 04:11:51]

On 2015/03/13 06:48:00, Lei Zhang wrote:
> On 2015/03/13 06:26:03, Anand Mistry wrote:
> >
>
https://codereview.chromium.org/1001283002/diff/1/chrome/browser/search/hotwo...
> > File chrome/browser/search/hotword_service_factory.cc (right):
> > 
> >
>
https://codereview.chromium.org/1001283002/diff/1/chrome/browser/search/hotwo...
> > chrome/browser/search/hotword_service_factory.cc:50: // Temporarily
disabling
> > hotword hardware check for M42. Will be
> > On 2015/03/13 06:19:32, Lei Zhang wrote:
> > > If you are not sure what milestone the feature will be ready in, consider
> > > changing it so that this feature is only enabled on dev/canary channel.
When
> > the
> > > feature is ready, remove the channel check. That way you don't have to do
> ToT
> > > commit + merge + ToT revert for every milestone.
> > 
> > Hm, how do you do that?
> 
> chrome::VersionInfo::GetChannel()

Thanks. I'll do that in a follow up since this needs to go in for M42 asap.

[Anand Mistry (off Chromium), 2015-03-14 04:12:11]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2015-03-14 04:12:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1001283002/1

[commit-bot: I haz the power, 2015-03-14 05:42:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-14 05:43:52]

Patchset 1 (id:??) landed as
https://crrev.com/61e6a0aa8c59a150474ba06f14ae4aa8521e4d5b
Cr-Commit-Position: refs/heads/master@{#320646}