pkg/analysis_server/test/services/completion/completion_test_util.dart - Issue 1001143002: remove duplicate completion suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 1001143002: remove duplicate completion suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/domain_completion_test.dart ('k') | pkg/analysis_server/test/services/completion/local_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_test_util.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart

index fccee33c1fc08215b7e6fe18ecffdf25e11e0f3c..bf924a941467765edbb1edc0b53304e1cd539c95 100644

--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart

+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart

@@ -1280,7 +1280,10 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

// 'num',

// false,

// COMPLETION_RELEVANCE_LOW);

- assertSuggestTopLevelVarGetterSetter('T1', 'String');

+ if (computer is ImportedComputer) {

+ // TODO(danrubel) should be top level var suggestion

+ assertSuggestGetter('T1', 'String');

+ }

assertNotSuggested('_T2');

//assertSuggestImportedTopLevelVar('T3', 'int', COMPLETION_RELEVANCE_LOW);

assertNotSuggested('_T4');

@@ -2589,7 +2592,9 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {

assertSuggestImportedFunction('nowIsIt', null);

assertNotSuggested('T1');

// TODO (danrubel) this really should be TopLevelVar not getter/setter

- assertSuggestTopLevelVarGetterSetter('newT1', 'int');

+ if (computer is ImportedComputer) {

+ assertSuggestGetter('newT1', 'int');

+ }

assertNotSuggested('z');

assertSuggestLocalTopLevelVar('m', 'dynamic');

assertSuggestLocalFunction('newer', 'String');