Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1001123003: Fix text clipping in FPS and CompositorFrameTime Display (Closed)

Created:
5 years, 9 months ago by patro
Modified:
5 years, 9 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix text clipping in FPS and CompositorFrameTime Display In Compositor Frame Time counter the text "time(ms)" gets chopped from right side. Also in FPS Display "GPU raster" status get chopped from right side. This is caused due to width constraint. Rearranging the Display items to display all items properly BUG=445877 Committed: https://crrev.com/17a1743f3207d909dd72a76bcde8f3aea5b0d6b3 Cr-Commit-Position: refs/heads/master@{#321514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M cc/layers/heads_up_display_layer_impl.cc View 4 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
patro
Kindly Review Thanks Patro
5 years, 9 months ago (2015-03-19 10:00:18 UTC) #2
danakj
Mind throwing up a screenshot of the changes?
5 years, 9 months ago (2015-03-19 16:26:00 UTC) #3
patro
On 2015/03/19 16:26:00, danakj wrote: > Mind throwing up a screenshot of the changes? Hi ...
5 years, 9 months ago (2015-03-19 18:46:48 UTC) #4
danakj
LGTM
5 years, 9 months ago (2015-03-19 20:59:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001123003/1
5 years, 9 months ago (2015-03-20 02:48:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 04:18:13 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 04:18:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17a1743f3207d909dd72a76bcde8f3aea5b0d6b3
Cr-Commit-Position: refs/heads/master@{#321514}

Powered by Google App Engine
This is Rietveld 408576698