Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8068)

Unified Diff: chrome/installer/mac/sign_versioned_dir.sh.in

Issue 1001103002: Crashpad! (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sign crashpad_handler Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mac/sign_app.sh.in ('k') | chrome/tools/build/mac/dump_product_syms » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mac/sign_versioned_dir.sh.in
diff --git a/chrome/installer/mac/sign_versioned_dir.sh.in b/chrome/installer/mac/sign_versioned_dir.sh.in
index 82a11c696b354d1828b56ede9b5828a3f72a362f..73a315a6b7b827a5f8b410ad1235f5d2bb878641 100644
--- a/chrome/installer/mac/sign_versioned_dir.sh.in
+++ b/chrome/installer/mac/sign_versioned_dir.sh.in
@@ -41,6 +41,7 @@ versioned_dir="${app_path}/Contents/Versions/@VERSION@"
# signed directly. See copy_framework_unversioned.sh.
framework="${versioned_dir}/@MAC_PRODUCT_NAME@ Framework.framework"
+crashpad_handler="${framework}/Helpers/crashpad_handler"
helper_app="${versioned_dir}/@MAC_PRODUCT_NAME@ Helper.app"
helper_eh_app="${versioned_dir}/@MAC_PRODUCT_NAME@ Helper EH.app"
helper_np_app="${versioned_dir}/@MAC_PRODUCT_NAME@ Helper NP.app"
@@ -50,6 +51,9 @@ and certificate leaf = H\"85cee8254216185620ddc8851c7a9fc4dfe120ef\"\
"
codesign --sign "${codesign_id}" --keychain "${codesign_keychain}" \
+ "${crashpad_handler}" \
+ -r="designated => identifier \"crashpad_handler\" \
+codesign --sign "${codesign_id}" --keychain "${codesign_keychain}" \
"${framework}" \
-r="designated => identifier \"com.google.Chrome.framework\" \
${requirement_suffix}"
@@ -68,6 +72,7 @@ ${requirement_suffix}"
# Verify everything. Don't use --deep on the framework because Keystone's
# signature is in a transitional state (radar 18474911).
+codesign --verify --deep "${crashpad_handler}"
codesign --verify "${framework}"
codesign --verify --deep "${helper_app}"
codesign --verify --deep "${helper_eh_app}"
« no previous file with comments | « chrome/installer/mac/sign_app.sh.in ('k') | chrome/tools/build/mac/dump_product_syms » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698