Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1001043004: Revamp desktop Autofill settings, round 2 (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, browser-components-watch_chromium.org, arv+watch_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revamp desktop Autofill settings, round 2 BUG=446698 NOPRESUBMIT=true Committed: https://crrev.com/884a7f0a7db9c0d7c95038e191a2c0d1c9920f2b Cr-Commit-Position: refs/heads/master@{#320573}

Patch Set 1 #

Patch Set 2 : grit whitelist #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : . #

Patch Set 5 : fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -46 lines) Patch
M build/ios/grit_whitelist.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.css View 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.html View 1 2 3 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.js View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/autofill_options_list.js View 1 2 3 4 chunks +29 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 2 3 5 chunks +13 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card.h View 2 chunks +5 lines, -3 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +13 lines, -7 lines 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill_strings.grdp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Evan Stade
5 years, 9 months ago (2015-03-12 23:06:49 UTC) #2
please use gerrit instead
https://codereview.chromium.org/1001043004/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1001043004/diff/40001/chrome/app/generated_resources.grd#newcode10506 chrome/app/generated_resources.grd:10506: +<<<<<<< HEAD Please fix.
5 years, 9 months ago (2015-03-13 18:25:52 UTC) #3
please use gerrit instead
lgtm
5 years, 9 months ago (2015-03-13 19:27:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001043004/60001
5 years, 9 months ago (2015-03-13 19:30:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/5307)
5 years, 9 months ago (2015-03-13 19:39:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001043004/80001
5 years, 9 months ago (2015-03-13 19:53:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/49616)
5 years, 9 months ago (2015-03-13 20:13:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001043004/80001
5 years, 9 months ago (2015-03-13 20:45:54 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-13 21:06:19 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 21:08:10 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/884a7f0a7db9c0d7c95038e191a2c0d1c9920f2b
Cr-Commit-Position: refs/heads/master@{#320573}

Powered by Google App Engine
This is Rietveld 408576698