chrome/renderer/safe_browsing/phishing_classifier_delegate.cc - Issue 1001043002: Refactor NavigationState to use NavigationParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

Issue 1001043002: Refactor NavigationState to use NavigationParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc b/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

index fb700e440a8ee828a56aa84bd7f9b19b57ba724a..4993280f416b3f2364a106a9e0a9d5d3d38d3a58 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

@@ -154,10 +154,11 @@ void PhishingClassifierDelegate::DidCommitProvisionalLoad(

DocumentState* document_state = DocumentState::FromDataSource(

frame->dataSource());

NavigationState* navigation_state = document_state->navigation_state();

- CancelPendingClassification(navigation_state->was_within_same_page() ?

- NAVIGATE_WITHIN_PAGE : NAVIGATE_AWAY);

+ CancelPendingClassification(navigation_state->WasWithinSamePage()

+ ? NAVIGATE_WITHIN_PAGE

+ : NAVIGATE_AWAY);

if (frame == render_view()->GetWebView()->mainFrame()) {

- last_main_frame_transition_ = navigation_state->transition_type();

+ last_main_frame_transition_ = navigation_state->GetTransitionType();

}