tools/auto_bisect/query_crbug_test.py - Issue 1001033004: Fix style in tools/auto_bisect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/auto_bisect/query_crbug_test.py

Issue 1001033004: Fix style in tools/auto_bisect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/auto_bisect/query_crbug_test.py

diff --git a/tools/auto_bisect/query_crbug_test.py b/tools/auto_bisect/query_crbug_test.py

index 40e6fa853eec8b588cfe0188daf6d95395cfb7f0..5406487542f1e9ca239f8c15884c51e9815e140e 100644

--- a/tools/auto_bisect/query_crbug_test.py

+++ b/tools/auto_bisect/query_crbug_test.py

@@ -27,7 +27,7 @@ UNEXPECTED_FORMAT_DATA = CLOSED_ISSUE_DATA.replace('issues$state', 'gibberish')

BROKEN_ISSUE_DATA = "\n<HTML><HEAD><TITLE>Not a JSON Doc</TITLE></HEAD></HTML>"

-class mockResponse(object):

+class MockResponse(object):

def __init__(self, result):

self._result = result

@@ -35,45 +35,45 @@ class mockResponse(object):

return self._result

-def mockUrlOpen(url):

+def MockUrlOpen(url):

# Note that these strings DO NOT represent http responses. They are just

# memorable numeric bug ids to use.

if '200' in url:

- return mockResponse(CLOSED_ISSUE_DATA)

+ return MockResponse(CLOSED_ISSUE_DATA)

elif '201' in url:

- return mockResponse(OPEN_ISSUE_DATA)

+ return MockResponse(OPEN_ISSUE_DATA)

elif '300' in url:

- return mockResponse(UNEXPECTED_FORMAT_DATA)

+ return MockResponse(UNEXPECTED_FORMAT_DATA)

elif '403' in url:

raise urllib2.URLError('')

elif '404' in url:

- return mockResponse('')

+ return MockResponse('')

elif '500' in url:

- return mockResponse(BROKEN_ISSUE_DATA)

+ return MockResponse(BROKEN_ISSUE_DATA)

class crbugQueryTest(unittest.TestCase):